feat(validation): support JSON Schema referencing in validation utils #4508
Conversation
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
There was a problem hiding this comment.
Hello @danieljnchen! Thans a lot for this super quick and very useful PR! We really need to offer this support to our customers.
I left a comment before I started doing a more detailed review.
Thank you and please ping me if you have any difficulties and I can help.
Uh oh!
There was an error while loading. Please reload this page.
|
|
Alright, my development environment is all set up, and I've run the |
Hi @danieljnchen! This is amazing! I'm reviewing this PR and if I find something small and easy to fix, I'll push some commits to get it merged quickly! Thank you very much for taking the time to make this improvement! |
@leandrodamascena (and @heitorlessa) thanks for your help getting this PR all cleaned up! I'm really excited to see this go in -- this is my first time contributing to an open-source project (I tried with python-dateutil a while back, but my MR never got reviewed). I appreciate the responsiveness and encouragement! |
2191346
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: #4499
Summary
Changes
This change updates aws-lambda-powertools' validation functions to support passing the
handlersparam to fastjsonschema's validate call.Customers now can use this new parameter
User experience
Users previously were unable to use schemas with JSON Schema references
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.