fix(parser): make etag optional field on S3 notification events #4173

benjamingorman · 2024-04-20T21:35:22Z

Issue number: #4156

Summary

etag is not guaranteed to be present on an S3 event (if it's a DeleteObject event for example) so this MR changes the type of etag on S3EventNotificationObjectModel to be Optional.

Changes

Please provide a summary of what's being changed

Modified S3EventNotificationObjectModel
Modified S3EventBridgeNotificationObject

User experience

Please share what the user experience looks like before and after this change

Before: S3 DeleteObject event fails to parse, with a pydantic validation error

After: S3 DeleteObject event is parsed correctly

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Meet tenets criteria
I have performed a self-review of this change
Changes have been tested
[] Changes are documented
PR title follows conventional commit semantics

Is this a breaking change?

It simply reflects the reality of the event in AWS.

RFC issue number:

Checklist:

Migration process documented
Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

boring-cyborg · 2024-04-20T21:35:25Z

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

codecov-commenter · 2024-04-22T08:30:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (e14e768) to head (0fe964d).
Report is 407 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4173      +/-   ##
===========================================
- Coverage    96.38%   96.31%   -0.07%     
===========================================
  Files          214      217       +3     
  Lines        10030    10437     +407     
  Branches      1846     1930      +84     
===========================================
+ Hits          9667    10052     +385     
- Misses         259      270      +11     
- Partials       104      115      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

leandrodamascena · 2024-04-22T10:04:28Z

Thanks for submitting the PR @benjamingorman! I think we need to change other fields like size, version_id and sequencer in the event source data class. They are already optional in Parser and based on the payload you sent they are not present.

Let me fix this and push a commit.

am29d · 2024-04-24T09:40:21Z

Make also sure to remove the etag and size from the test event in

powertools-lambda-python/tests/events/s3EventBridgeNotificationObjectDeletedEvent.json

Line 20 in fe26d1c

"etag": "4e68adba0abe2dc8653dc3354e14c01d",

heitorlessa · 2024-05-07T08:58:45Z

Looking...

… when possible

heitorlessa · 2024-05-07T09:39:59Z

Pushed the fixes for tests and used sane defaults for etag (S3->EventBridge) and eTag (S3->Lambda/SNS/SQS).

Improved docstrings to explain when that's the case. Pending CI and we can merge.

dreamorosi · 2024-05-07T09:45:46Z

For reference, I have tested the events with an actual stack, these are two examples of events that trigger a function:

{
    "version": "0",
    "id": "1d0e793f-a560-c0b2-9f0f-f0046cf8d051",
    "detail-type": "Object Created",
    "source": "aws.s3",
    "account": "536254204126",
    "time": "2024-05-07T09:31:21Z",
    "region": "eu-west-1",
    "resources": [
        "arn:aws:s3:::s3teststack-mybucketf68f3ff0-gscrrokfnvnw"
    ],
    "detail": {
        "version": "0",
        "bucket": {
            "name": "s3teststack-mybucketf68f3ff0-gscrrokfnvnw"
        },
        "object": {
            "key": "surprised-pikachu.gif",
            "size": 2638774,
            "etag": "fb21c5a0ff18e29aab890d1d1f6d6e64",
            "sequencer": "006639F4E9AAD27BAD"
        },
        "request-id": "ACJYMRYT9T7HS3KE",
        "requester": "536254204126",
        "source-ip-address": "15.248.3.15",
        "reason": "PutObject"
    }
}

and

{
    "version": "0",
    "id": "46bf2718-5e27-a74d-ec6b-2d95d4e21844",
    "detail-type": "Object Deleted",
    "source": "aws.s3",
    "account": "536254204126",
    "time": "2024-05-07T09:31:52Z",
    "region": "eu-west-1",
    "resources": [
        "arn:aws:s3:::s3teststack-mybucketf68f3ff0-gscrrokfnvnw"
    ],
    "detail": {
        "version": "0",
        "bucket": {
            "name": "s3teststack-mybucketf68f3ff0-gscrrokfnvnw"
        },
        "object": {
            "key": "surprised-pikachu.gif",
            "sequencer": "006639F508B96A7690"
        },
        "request-id": "11K82SGF9X2HBEKD",
        "requester": "536254204126",
        "source-ip-address": "15.248.3.15",
        "reason": "DeleteObject",
        "deletion-type": "Permanently Deleted"
    }
}

heitorlessa · 2024-05-07T09:49:31Z

checking shortly, just updating the main issue

sonarqubecloud · 2024-05-07T09:56:38Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
15.7% Duplication on New Code

See analysis details on SonarCloud

boring-cyborg · 2024-05-07T10:01:02Z

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

* chore(deps): bump squidfunk/mkdocs-material from `e309089` to `98c9809` in /docs (#4236) chore(deps): bump squidfunk/mkdocs-material in /docs Bumps squidfunk/mkdocs-material from `e309089` to `98c9809`. --- updated-dependencies: - dependency-name: squidfunk/mkdocs-material dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump pytest from 8.1.1 to 8.2.0 (#4237) Bumps [pytest](https://github.com/pytest-dev/pytest) from 8.1.1 to 8.2.0. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@8.1.1...8.2.0) --- updated-dependencies: - dependency-name: pytest dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump actions/dependency-review-action from 4.2.5 to 4.3.1 (#4240) Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 4.2.5 to 4.3.1. - [Release notes](https://github.com/actions/dependency-review-action/releases) - [Commits](actions/dependency-review-action@5bbc3ba...e58c696) --- updated-dependencies: - dependency-name: actions/dependency-review-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump mkdocs-material from 9.5.19 to 9.5.20 (#4242) Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.19 to 9.5.20. - [Release notes](https://github.com/squidfunk/mkdocs-material/releases) - [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG) - [Commits](squidfunk/mkdocs-material@9.5.19...9.5.20) --- updated-dependencies: - dependency-name: mkdocs-material dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump cdklabs-generative-ai-cdk-constructs from 0.1.131 to 0.1.132 (#4239) chore(deps-dev): bump cdklabs-generative-ai-cdk-constructs Bumps [cdklabs-generative-ai-cdk-constructs](https://github.com/awslabs/generative-ai-cdk-constructs) from 0.1.131 A3E2 to 0.1.132. - [Release notes](https://github.com/awslabs/generative-ai-cdk-constructs/releases) - [Changelog](https://github.com/awslabs/generative-ai-cdk-constructs/blob/main/CHANGELOG.md) - [Commits](awslabs/generative-ai-cdk-constructs@v0.1.131...v0.1.132) --- updated-dependencies: - dependency-name: cdklabs-generative-ai-cdk-constructs dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump hvac from 2.1.0 to 2.2.0 (#4238) Bumps [hvac](https://github.com/hvac/hvac) from 2.1.0 to 2.2.0. - [Release notes](https://github.com/hvac/hvac/releases) - [Changelog](https://github.com/hvac/hvac/blob/main/CHANGELOG.md) - [Commits](hvac/hvac@v2.1.0...v2.2.0) --- updated-dependencies: - dependency-name: hvac dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump filelock from 3.13.4 to 3.14.0 (#4241) Bumps [filelock](https://github.com/tox-dev/py-filelock) from 3.13.4 to 3.14.0. - [Release notes](https://github.com/tox-dev/py-filelock/releases) - [Changelog](https://github.com/tox-dev/filelock/blob/main/docs/changelog.rst) - [Commits](tox-dev/filelock@3.13.4...3.14.0) --- updated-dependencies: - dependency-name: filelock dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump actions/dependency-review-action from 4.3.1 to 4.3.2 (#4244) Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 4.3.1 to 4.3.2. - [Release notes](https://github.com/actions/dependency-review-action/releases) - [Commits](actions/dependency-review-action@e58c696...0c155c5) --- updated-dependencies: - dependency-name: actions/dependency-review-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump aws-cdk from 2.139.0 to 2.139.1 (#4245) Bumps [aws-cdk](https://github.com/aws/aws-cdk/tree/HEAD/packages/aws-cdk) from 2.139.0 to 2.139.1. - [Release notes](https://github.com/aws/aws-cdk/releases) - [Changelog](https://github.com/aws/aws-cdk/blob/main/CHANGELOG.v2.md) - [Commits](https://github.com/aws/aws-cdk/commits/v2.139.1/packages/aws-cdk) --- updated-dependencies: - dependency-name: aws-cdk dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump codecov/codecov-action from 4.3.0 to 4.3.1 (#4252) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.3.0 to 4.3.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@8450866...5ecb98a) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump cdklabs-generative-ai-cdk-constructs from 0.1.132 to 0.1.133 (#4246) chore(deps-dev): bump cdklabs-generative-ai-cdk-constructs Bumps [cdklabs-generative-ai-cdk-constructs](https://github.com/awslabs/generative-ai-cdk-constructs) from 0.1.132 to 0.1.133. - [Release notes](https://github.com/awslabs/generative-ai-cdk-constructs/releases) - [Changelog](https://github.com/awslabs/generative-ai-cdk-constructs/blob/main/CHANGELOG.md) - [Commits](awslabs/generative-ai-cdk-constructs@v0.1.132...v0.1.133) --- updated-dependencies: - dependency-name: cdklabs-generative-ai-cdk-constructs dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump datadog-lambda from 5.93.0 to 5.94.0 (#4253) Bumps [datadog-lambda](https://github.com/DataDog/datadog-lambda-python) from 5.93.0 to 5.94.0. - [Release notes](https://github.com/DataDog/datadog-lambda-python/releases) - [Commits](DataDog/datadog-lambda-python@v5.93.0...v5.94.0) --- updated-dependencies: - dependency-name: datadog-lambda dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump pytest-xdist from 3.5.0 to 3.6.1 (#4247) Bumps [pytest-xdist](https://github.com/pytest-dev/pytest-xdist) from 3.5.0 to 3.6.1. - [Release notes](https://github.com/pytest-dev/pytest-xdist/releases) - [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest-xdist@v3.5.0...v3.6.1) --- updated-dependencies: - dependency-name: pytest-xdist dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump cfn-lint from 0.86.4 to 0.87.0 (#4249) Bumps [cfn-lint](https://github.com/aws-cloudformation/cfn-python-lint) from 0.86.4 to 0.87.0. - [Release notes](https://github.com/aws-cloudformation/cfn-python-lint/releases) - [Changelog](https://github.com/aws-cloudformation/cfn-lint/blob/main/CHANGELOG.md) - [Commits](aws-cloudformation/cfn-lint@v0.86.4...v0.87.0) --- updated-dependencies: - dependency-name: cfn-lint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump aws-cdk-lib from 2.139.0 to 2.139.1 (#4248) Bumps [aws-cdk-lib](https://github.com/aws/aws-cdk) from 2.139.0 to 2.139.1. - [Release notes](https://github.com/aws/aws-cdk/releases) - [Changelog](https://github.com/aws/aws-cdk/blob/main/CHANGELOG.v2.md) - [Commits](aws/aws-cdk@v2.139.0...v2.139.1) --- updated-dependencies: - dependency-name: aws-cdk-lib dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(ci): changelog rebuild (#4254) Co-authored-by: Powertools for AWS Lambda (Python) bot <151832416+aws-powertools-bot@users.noreply.github.com> * fix(ci): apply lessons learned to monthly roadmap reminder cross-repo (#4078) * fix(parameters): make cache aware of single vs multiple calls Signed-off-by: heitorlessa <lessa@amazon.co.uk> * chore: cleanup, add test for single and nested Signed-off-by: heitorlessa <lessa@amazon.co.uk> * chore: first experiment with central but private workflow * chore: test workflow * chore(ci): test with branch over sha as it was not found * chore(ci): use secrets for new workflow_call * chore(ci): update named secret input * chore(ci): apply least-privilege permissions at job level * chore(ci): make monthly roadmap reminder workflow immutable for sec * chore(ci): add note about cronjob * chore: add powertools actions to allow list until releases are done Signed-off-by: heitorlessa <lessa@amazon.co.uk> --------- Signed-off-by: heitorlessa <lessa@amazon.co.uk> Signed-off-by: Heitor Lessa <lessa@amazon.com> * chore(deps-dev): bump mypy-boto3-dynamodb from 1.34.91 to 1.34.97 in the boto-typing group (#4257) chore(deps-dev): bump mypy-boto3-dynamodb in the boto-typing group Bumps the boto-typing group with 1 update: [mypy-boto3-dynamodb](https://github.com/youtype/mypy_boto3_builder). Updates `mypy-boto3-dynamodb` from 1.34.91 to 1.34.97 - [Release notes](https://github.com/youtype/mypy_boto3_builder/releases) - [Commits](https://github.com/youtype/mypy_boto3_builder/commits) --- updated-dependencies: - dependency-name: mypy-boto3-dynamodb dependency-type: direct:development update-type: version-update:semver-patch dependency-group: boto-typing ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump aws-cdk from 2.139.1 to 2.140.0 (#4256) Bumps [aws-cdk](https://github.com/aws/aws-cdk/tree/HEAD/packages/aws-cdk) from 2.139.1 to 2.140.0. - [Release notes](https://github.com/aws/aws-cdk/releases) - [Changelog](https://github.com/aws/aws-cdk/blob/main/CHANGELOG.v2.md) - [Commits](https://github.com/aws/aws-cdk/commits/v2.140.0/packages/aws-cdk) --- updated-dependencies: - dependency-name: aws-cdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump cdklabs-generative-ai-cdk-constructs from 0.1.133 to 0.1.134 (#4260) chore(deps-dev): bump cdklabs-generative-ai-cdk-constructs Bumps [cdklabs-generative-ai-cdk-constructs](https://github.com/awslabs/generative-ai-cdk-constructs) from 0.1.133 to 0.1.134. - [Release notes](https://github.com/awslabs/generative-ai-cdk-constructs/releases) - [Changelog](https://github.com/awslabs/generative-ai-cdk-constructs/blob/main/CHANGELOG.md) - [Commits](awslabs/generative-ai-cdk-constructs@v0.1.133...v0.1.134) --- updated-dependencies: - dependency-name: cdklabs-generative-ai-cdk-constructs dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump aws-cdk-aws-lambda-python-alpha from 2.139.0a0 to 2.139.1a0 (#4261) chore(deps-dev): bump aws-cdk-aws-lambda-python-alpha Bumps [aws-cdk-aws-lambda-python-alpha](https://github.com/aws/aws-cdk) from 2.139.0a0 to 2.139.1a0. - [Release notes](https://github.com/aws/aws-cdk/releases) - [Changelog](https://github.com/aws/aws-cdk/blob/main/CHANGELOG.v2.md) - [Commits](https://github.com/aws/aws-cdk/commits) --- updated-dependencies: - dependency-name: aws-cdk-aws-lambda-python-alpha dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump slsa-framework/slsa-github-generator from 1.10.0 to 2.0.0 (#4179) * chore(deps): bump slsa-framework/slsa-github-generator Bumps [slsa-framework/slsa-github-generator](https://github.com/slsa-framework/slsa-github-generator) from 1.10.0 to 2.0.0. - [Release notes](https://github.com/slsa-framework/slsa-github-generator/releases) - [Changelog](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md) - [Commits](slsa-framework/slsa-github-generator@v1.10.0...v2.0.0) --- updated-dependencies: - dependency-name: slsa-framework/slsa-github-generator dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * chore(ci): upgrade download-action to v4 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: heitorlessa <lessa@amazon.co.uk> * chore(deps-dev): bump aws-cdk-lib from 2.139.1 to 2.140.0 (#4259) Bumps [aws-cdk-lib](https://github.com/aws/aws-cdk) from 2.139.1 to 2.140.0. - [Release notes](https://github.com/aws/aws-cdk/releases) - [Changelog](https://github.com/aws/aws-cdk/blob/main/CHANGELOG.v2.md) - [Commits](aws/aws-cdk@v2.139.1...v2.140.0) --- updated-dependencies: - dependency-name: aws-cdk-lib dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump mike from 1.1.2 to 2.1.0 (#4258) Bumps [mike](https://github.com/jimporter/mike) from 1.1.2 to 2.1.0. - [Release notes](https://github.com/jimporter/mike/releases) - [Changelog](https://github.com/jimporter/mike/blob/master/CHANGES.md) - [Commits](jimporter/mike@v1.1.2...v2.1.0) --- updated-dependencies: - dependency-name: mike dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(ci): changelog rebuild (#4262) Co-authored-by: Powertools for AWS Lambda (Python) bot <151832416+aws-powertools-bot@users.noreply.github.com> * chore(deps-dev): bump mike from 2.1.0 to 2.1.1 (#4268) Bumps [mike](https://github.com/jimporter/mike) from 2.1.0 to 2.1.1. - [Release notes](https://github.com/jimporter/mike/releases) - [Changelog](https://github.com/jimporter/mike/blob/master/CHANGES.md) - [Commits](jimporter/mike@v2.1.0...v2.1.1) --- updated-dependencies: - dependency-name: mike dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump mkdocs-material from 9.5.20 to 9.5.21 (#4271) Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.20 to 9.5.21. - [Release notes](https://github.com/squidfunk/mkdocs-material/releases) - [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG) - [Commits](squidfunk/mkdocs-material@9.5.20...9.5.21) --- updated-dependencies: - dependency-name: mkdocs-material dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump cfn-lint from 0.87.0 to 0.87.1 (#4272) Bumps [cfn-lint](https://github.com/aws-cloudformation/cfn-python-lint) from 0.87.0 to 0.87.1. - [Release notes](https://github.com/aws-cloudformation/cfn-python-lint/releases) - [Changelog](https://github.com/aws-cloudformation/cfn-lint/blob/main/CHANGELOG.md) - [Commits](aws-cloudformation/cfn-lint@v0.87.0...v0.87.1) --- updated-dependencies: - dependency-name: cfn-lint dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump aws-cdk-aws-lambda-python-alpha from 2.139.1a0 to 2.140.0a0 (#4270) chore(deps-dev): bump aws-cdk-aws-lambda-python-alpha Bumps [aws-cdk-aws-lambda-python-alpha](https://github.com/aws/aws-cdk) from 2.139.1a0 to 2.140.0a0. - [Release notes](https://github.com/aws/aws-cdk/releases) - [Changelog](https://github.com/aws/aws-cdk/blob/main/CHANGELOG.v2.md) - [Commits](https://github.com/aws/aws-cdk/commits) --- updated-dependencies: - dependency-name: aws-cdk-aws-lambda-python-alpha dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump cdklabs-generative-ai-cdk-constructs from 0.1.134 to 0.1.135 (#4273) chore(deps-dev): bump cdklabs-generative-ai-cdk-constructs Bumps [cdklabs-generative-ai-cdk-constructs](https://github.com/awslabs/generative-ai-cdk-constructs) from 0.1.134 to 0.1.135. - [Release notes](https://github.com/awslabs/generative-ai-cdk-constructs/releases) - [Changelog](https://github.com/awslabs/generative-ai-cdk-constructs/blob/main/CHANGELOG.md) - [Commits](awslabs/generative-ai-cdk-constructs@v0.1.134...v0.1.135) --- updated-dependencies: - dependency-name: cdklabs-generative-ai-cdk-constructs dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(ci): changelog rebuild (#4278) Co-authored-by: Powertools for AWS Lambda (Python) bot <151832416+aws-powertools-bot@users.noreply.github.com> * chore(deps): bump squidfunk/mkdocs-material from `98c9809` to `11d7ec0` in /docs (#4269) chore(deps): bump squidfunk/mkdocs-material in /docs Bumps squidfunk/mkdocs-material from `98c9809` to `11d7ec0`. --- updated-dependencies: - dependency-name: squidfunk/mkdocs-material dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(event_handler): add decorator for HTTP HEAD verb (#4275) chore(ci): changelog rebuild (#4262) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Powertools for AWS Lambda (Python) bot <151832416+aws-powertools-bot@users.noreply.github.com> Co-authored-by: Leandro Damascena <lcdama@amazon.pt> * chore(ci): changelog rebuild (#4289) Co-authored-by: Powertools for AWS Lambda (Python) bot <151832416+aws-powertools-bot@users.noreply.github.com> * chore(deps-dev): bump coverage from 7.5.0 to 7.5.1 (#4288) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump sentry-sdk from 2.0.1 to 2.1.1 (#4287) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump ruff from 0.4.2 to 0.4.3 (#4286) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump jinja2 from 3.1.3 to 3.1.4 (#4283) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump jinja2 from 3.1.3 to 3.1.4 in /docs (#4284) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump actions/checkout from 4.1.4 to 4.1.5 (#4282) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump zgosalvez/github-actions-ensure-sha-pinned-actions from 3.0.4 to 3.0.5 (#4281) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump cdklabs-generative-ai-cdk-constructs from 0.1.135 to 0.1.136 (#4285) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(typing): resolved_headers_field is not Optional (#4148) Co-authored-by: Heitor Lessa <lessa@amazon.com> * fix(parser): make etag optional field on S3 notification events (#4173) Co-authored-by: Leandro Damascena <lcdama@amazon.pt> Co-authored-by: Heitor Lessa <lessa@amazon.com> * docs(homepage): add link to new and official workshop (#4292) * chore(deps-dev): bump cdklabs-generative-ai-cdk-constructs from 0.1.136 to 0.1.139 (#4293) chore(deps-dev): bump cdklabs-generative-ai-cdk-constructs Bumps [cdklabs-generative-ai-cdk-constructs](https://github.com/awslabs/generative-ai-cdk-constructs) from 0.1.136 to 0.1.139. - [Release notes](https://github.com/awslabs/generative-ai-cdk-constructs/releases) - [Changelog](https://github.com/awslabs/generative-ai-cdk-constructs/blob/main/CHANGELOG.md) - [Commits](awslabs/generative-ai-cdk-constructs@v0.1.136...v0.1.139) --- updated-dependencies: - dependency-name: cdklabs-generative-ai-cdk-constructs dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(ci): changelog rebuild (#4294) Co-authored-by: Powertools for AWS Lambda (Python) bot <151832416+aws-powertools-bot@users.noreply.github.com> * chore(governance): add FastAPI third party license attribution (#4297) * chore(deps): bump the layer-balancer group in /layer/scripts/layer-balancer with 2 updates (#4302) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(ci): changelog rebuild (#4304) Co-authored-by: Powertools for AWS Lambda (Python) bot <151832416+aws-powertools-bot@users.noreply.github.com> * chore(deps-dev): bump cdklabs-generative-ai-cdk-constructs from 0.1.139 to 0.1.140 (#4301) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(event-sources): sane defaults for authorizer v1 and v2 (#4298) * fix(parameters): make cache aware of single vs multiple calls Signed-off-by: heitorlessa <lessa@amazon.co.uk> * chore: cleanup, add test for single and nested Signed-off-by: heitorlessa <lessa@amazon.co.uk> * chore(ci): add first centralized reusable workflow * fix(event-sources): default dict and list in authorizers when not found * chore: mypy constant type * Delete bla.py * Delete playground/.prettierrc * Delete playground/app.mjs --------- Signed-off-by: heitorlessa <lessa@amazon.co.uk> Co-authored-by: Leandro Damascena <lcdama@amazon.pt> * chore(deps-dev): bump cdklabs-generative-ai-cdk-constructs from 0.1.140 to 0.1.142 (#4307) chore(deps-dev): bump cdklabs-generative-ai-cdk-constructs Bumps [cdklabs-generative-ai-cdk-constructs](https://github.com/awslabs/generative-ai-cdk-constructs) from 0.1.140 to 0.1.142. - [Release notes](https://github.com/awslabs/generative-ai-cdk-constructs/releases) - [Changelog](https://github.com/awslabs/generative-ai-cdk-constructs/blob/main/CHANGELOG.md) - [Commits](awslabs/generative-ai-cdk-constructs@v0.1.140...v0.1.142) --- updated-dependencies: - dependency-name: cdklabs-generative-ai-cdk-constructs dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump aws-cdk from 2.140.0 to 2.141.0 (#4306) Bumps [aws-cdk](https://github.com/aws/aws-cdk/tree/HEAD/packages/aws-cdk) from 2.140.0 to 2.141.0. - [Release notes](https://github.com/aws/aws-cdk/releases) - [Changelog](https://github.com/aws/aws-cdk/blob/main/CHANGELOG.v2.md) - [Commits](https://github.com/aws/aws-cdk/commits/v2.141.0/packages/aws-cdk) --- updated-dependencies: - dependency-name: aws-cdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Leandro Damascena <lcdama@amazon.pt> * chore(deps-dev): bump aws-cdk-lib from 2.140.0 to 2.141.0 (#4308) Bumps [aws-cdk-lib](https://github.com/aws/aws-cdk) from 2.140.0 to 2.141.0. - [Release notes](https://github.com/aws/aws-cdk/releases) - [Changelog](https://github.com/aws/aws-cdk/blob/main/CHANGELOG.v2.md) - [Commits](aws/aws-cdk@v2.140.0...v2.141.0) --- updated-dependencies: - dependency-name: aws-cdk-lib dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump ruff from 0.4.3 to 0.4.4 (#4309) Bumps [ruff](https://github.com/astral-sh/ruff) from 0.4.3 to 0.4.4. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@v0.4.3...v0.4.4) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(ci): changelog rebuild (#4311) Co-authored-by: Powertools for AWS Lambda (Python) bot <151832416+aws-powertools-bot@users.noreply.github.com> * chore(deps): bump ossf/scorecard-action from 2.3.1 to 2.3.3 (#4315) * chore(deps-dev): bump aws-cdk-aws-lambda-python-alpha from 2.140.0a0 to 2.141.0a0 (#4318) * chore(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.27.12 to 1.27.13 in /layer/scripts/layer-balancer in the layer-balancer group (#4319) * chore(deps-dev): bump cdklabs-generative-ai-cdk-constructs from 0.1.142 to 0.1.144 (#4316) * chore(ci): changelog rebuild (#4321) * chore(deps-dev): bump cfn-lint from 0.87.1 to 0.87.2 (#4317) * feat(event_handler): add support for persisting authorization session in OpenAPI (#4312) * feat(event_handler): add support for persisting authorization data in Swagger UI * docs(event_handler): update docs for Swagger UI persist authorization feature --------- Signed-off-by: Nicolas Lykke Iversen <14088508+nlykkei@users.noreply.github.com> Co-authored-by: Leandro Damascena <lcdama@amazon.pt> * chore(ci): changelog rebuild (#4322) Co-authored-by: Powertools for AWS Lambda (Python) bot <151832416+aws-powertools-bot@users.noreply.github.com> * fix(logger): correctly pick powertools or custom handler in custom environments (#4295) * fix(parameters): make cache aware of single vs multiple calls Signed-off-by: heitorlessa <lessa@amazon.co.uk> * chore: cleanup, add test for single and nested Signed-off-by: heitorlessa <lessa@amazon.co.uk> * chore(ci): add first centralized reusable workflow * fix: initial work on handler fix * fix: make it backwards compatible for children behaviour * chore: assert handlers; assert defaults create and use PT handler * Delete bla.py * chore: ignore bla * Delete playground/app.mjs * Delete playground/.prettierrc * chore: improve orphaned child side effect with an explicit error * fix: orphan exception must not be shadowed by attr exc * chore: mypy * docs(logger): clarify child loggers side effects; cleanup over-used banners * chore: ignore type checking test coverage * Fixing small things * Update constants.py Signed-off-by: Heitor Lessa <lessa@amazon.nl> * Update constants.py Signed-off-by: Heitor Lessa <lessa@amazon.nl> --------- Signed-off-by: heitorlessa <lessa@amazon.co.uk> Signed-off-by: Heitor Lessa <lessa@amazon.nl> Co-authored-by: Leandro Damascena <lcdama@amazon.pt> * chore(deps): bump squidfunk/mkdocs-material from `11d7ec0` to `8ef47d7` in /docs (#4323) chore(deps): bump squidfunk/mkdocs-material in /docs Bumps squidfunk/mkdocs-material from `11d7ec0` to `8ef47d7`. --- updated-dependencies: - dependency-name: squidfunk/mkdocs-material dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump cdklabs-generative-ai-cdk-constructs from 0.1.144 to 0.1.145 (#4325) chore(deps-dev): bump cdklabs-generative-ai-cdk-constructs Bumps [cdklabs-generative-ai-cdk-constructs](https://github.com/awslabs/generative-ai-cdk-constructs) from 0.1.144 to 0.1.145. - [Release notes](https://github.com/awslabs/generative-ai-cdk-constructs/releases) - [Changelog](https://github.com/awslabs/generative-ai-cdk-constructs/blob/main/CHANGELOG.md) - [Commits](awslabs/generative-ai-cdk-constructs@v0.1.144...v0.1.145) --- updated-dependencies: - dependency-name: cdklabs-generative-ai-cdk-constructs dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump mkdocs-material from 9.5.21 to 9.5.22 (#4324) Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.21 to 9.5.22. - [Release notes](https://github.com/squidfunk/mkdocs-material/releases) - [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG) - [Commits](squidfunk/mkdocs-material@9.5.21...9.5.22) --- updated-dependencies: - dependency-name: mkdocs-material dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(ci): changelog rebuild (#4326) Co-authored-by: Powertools for AWS Lambda (Python) bot <151832416+aws-powertools-bot@users.noreply.github.com> * chore(deps-dev): bump mypy-boto3-s3 from 1.34.91 to 1.34.105 in the boto-typing group (#4329) chore(deps-dev): bump mypy-boto3-s3 in the boto-typing group Bumps the boto-typing group with 1 update: [mypy-boto3-s3](https://github.com/youtype/mypy_boto3_builder). Updates `mypy-boto3-s3` from 1.34.91 to 1.34.105 - [Release notes](https://github.com/youtype/mypy_boto3_builder/releases) - [Commits](https://github.com/youtype/mypy_boto3_builder/commits) --- updated-dependencies: - dependency-name: mypy-boto3-s3 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: boto-typing ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump codecov/codecov-action from 4.3.1 to 4.4.0 (#4328) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.3.1 to 4.4.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@5ecb98a...6d79887) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump cdklabs-generative-ai-cdk-constructs from 0.1.145 to 0.1.146 (#4330) chore(deps-dev): bump cdklabs-generative-ai-cdk-constructs Bumps [cdklabs-generative-ai-cdk-constructs](https://github.com/awslabs/generative-ai-cdk-constructs) from 0.1.145 to 0.1.146. - [Release notes](https://github.com/awslabs/generative-ai-cdk-constructs/releases) - [Changelog](https://github.com/awslabs/generative-ai-cdk-constructs/blob/main/CHANGELOG.md) - [Commits](awslabs/generative-ai-cdk-constructs@v0.1.145...v0.1.146) --- updated-dependencies: - dependency-name: cdklabs-generative-ai-cdk-constructs dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(ci): changelog rebuild (#4331) Co-authored-by: Powertools for AWS Lambda (Python) bot <151832416+aws-powertools-bot@users.noreply.github.com> * refactor(data-masking): remove Non-GA comments (#4334) Removing comments * Merging from develop --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: heitorlessa <lessa@amazon.co.uk> Signed-off-by: Heitor Lessa <lessa@amazon.com> Signed-off-by: Nicolas Lykke Iversen <14088508+nlykkei@users.noreply.github.com> Signed-off-by: Heitor Lessa <lessa@amazon.nl> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Powertools for AWS Lambda (Python) bot <151832416+aws-powertools-bot@users.noreply.github.com> Co-authored-by: Heitor Lessa <lessa@amazon.com> Co-authored-by: heitorlessa <lessa@amazon.co.uk> Co-authored-by: Nicolas Lykke Iversen <14088508+nlykkei@users.noreply.github.com> Co-authored-by: Nico Tonnhofer <github@wurstnase.de> Co-authored-by: Benjamin Gorman <8076bgorman@gmail.com> Co-authored-by: Andrea Amorosi <dreamorosi@gmail.com>

Make etag Optional on S3EventNotificationObjectModel

ef1ba45

benjamingorman requested a review from a team April 20, 2024 21:35

pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 20, 2024

leandrodamascena changed the title ~~fix: Make etag Optional on S3EventNotificationObjectModel~~ fix(parser): make etag optional field on S3EventNotificationObjectModel Apr 22, 2024

github-actions bot added the bug Something isn't working label Apr 22, 2024

Merge branch 'develop' into feature/fix-etag-type

4c78593

leandrodamascena changed the title ~~fix(parser): make etag optional field on S3EventNotificationObjectModel~~ fix(parser): make etag optional field on S3 notification events Apr 22, 2024

benjamingorman added 2 commits April 25, 2024 12:22

Merge branch 'develop' into feature/fix-etag-type

8447d55

Remove etag and size from test event

68712d5

boring-cyborg bot added the tests label Apr 25, 2024

pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2024

dreamorosi mentioned this pull request May 7, 2024

Roadmap update reminder - May aws-powertools/actions#23

Closed

heitorlessa and others added 2 commits May 7, 2024 11:37

fix: use getters for optional etag and size; default to sane defaults…

bfbdcaa

… when possible

Merge branch 'develop' into feature/fix-etag-type

099c7d5

chore: ignore false positive mypy

4893b2e

fix(parser): set default value for etag field

0fe964d

heitorlessa merged commit 3a6dbe0 into aws-powertools:develop May 7, 2024
15 of 16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(parser): make etag optional field on S3 notification events #4173

fix(parser): make etag optional field on S3 notification events #4173

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix(parser): make etag optional field on S3 notification events #4173

fix(parser): make etag optional field on S3 notification events #4173

Uh oh!

Conversation

Summary

Changes

User experience

Checklist

Acknowledgment

Uh oh!

Uh oh!

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!

Uh oh!