fix(idempotency): revert dict mutation that impacted static_pk_value feature #1970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tankanow
reviewed
Mar 1, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1970 +/- ##
===========================================
+ Coverage 97.43% 97.44% +0.01%
===========================================
Files 146 146
Lines 6660 6660
Branches 478 478
===========================================
+ Hits 6489 6490 +1
Misses 134 134
+ Partials 37 36 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Tankanow
reviewed
Mar 1, 2023
|
Added co-authorship to the merge commit but as your email isn't public the no-reply might not credit it correctly (I'll do in the release regardless) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #1968
Summary
Changes
Reverts a regression added in #1899 when making DynamoDB client thread-safe.
static_pk_valueis used by customers using Single Table design pattern with DynamoDB, where a composite key is used with a static value for its "primary key" attr. This change reverts a dictionary mutation that discarded the value fromstatic_pk_valueand usedkey_idinstead.In simple terms, same effect as:
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.