build(deps): bump com.networknt:json-schema-validator from 1.0.87 to 1.4.3 #1674
Conversation
|
Thanks for submitting this PR. It looks good to me but I have 3 questions.
JsonSchemaFactory jsonSchemaFactory = JsonSchemaFactory.getInstance(VersionFlag.V202012, builder ->
builder.schemaMappers(schemaMappers -> schemaMappers.mapPrefix("https://www.example.org/", "classpath:schema/"))
); |
...s-validation/src/main/java/software/amazon/lambda/powertools/validation/ValidationUtils.java
Show resolved
Hide resolved
There were breaking API changes, but given that it doesn't seem like this library provides much options to customize the validator I'm not sure it applies here, like if users had custom keyword or format implementations etc that would require code changes. This fixes a lot of issues with respect to compliance with the specifications with respect to the validation so if users relied on incorrect behavior that will break. For instance previously certain keywords for 2019-09 and in particular 2020-12 didn't work eg
I'm not really sure which aspect of the documentation would require updating. The message is likely the most visible change.
There's actually no need to do that for the standard schema dialects because the |
|
@justin-tay, Can you try to run the two end-to-end tests in powertools-e2e-tests ? Then if it works we should be good. Thank you. |
|
Will there be any costs involved running the two end-to-end tests in powertools-e2e-tests? |
|
The |
|
I only ran [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 51.41 s -- in software.amazon.lambda.powertools.ValidationApiGWE2ET
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] |
Issue #, if available: #1663
Description of changes:
Upgrades com.networknt:json-schema-validator to 1.4.3.
Note that the validation error messages have changed since 1.0.87.
{ "validationErrors": [ { "type": "enum", "code": "1008", "message": "/properties/name/type: does not have a value in the enumeration [array, boolean, integer, null, number, object, string]", "instanceLocation": "/properties/name/type", "evaluationPath": "/properties/properties/additionalProperties/$ref/properties/type/anyOf/0/$ref/enum", "schemaLocation": "http://json-schema.org/draft-07/schema#/definitions/simpleTypes/enum", "messageKey": "enum", "arguments": [ "[array, boolean, integer, null, number, object, string]" ] }, { "type": "type", "code": "1029", "message": "/properties/name/type: string found, array expected", "instanceLocation": "/properties/name/type", "evaluationPath": "/properties/properties/additionalProperties/$ref/properties/type/anyOf/1/type", "schemaLocation": "http://json-schema.org/draft-07/schema#/properties/type/anyOf/1/type", "messageKey": "type", "arguments": [ "string", "array" ] } ] }Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.