chore(v2): Split powertools idempotency module (without redis impl) #1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
|
It's not clear to me if |
801edf2 to
6f214c2
Compare
💾 Artifacts Size Report
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## v2 #1559 +/- ##
=====================================
Coverage ? 89.79%
Complexity ? 406
=====================================
Files ? 44
Lines ? 1274
Branches ? 165
=====================================
Hits ? 1144
Misses ? 88
Partials ? 42 ☔ View full report in Codecov by Sentry. |
478e790 to
6a3be41
Compare
6a3be41 to
f5928ec
Compare
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1504
Description of changes:
Takes @eldimi 's changes from #1513 for the module split only. I've rebased the commits from
0ec7f4a0d7424c24cb402f23f6896111f257ac44to6da6aaf6b558edb56b18dd71e2f0ed1a7a8d8d13inclusive onto v2. We will merge this and take the redis implementation in later.Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.