8000 chore: Add 'v2' branch to build workflows by scottgerring · Pull Request #1341 · aws-powertools/powertools-lambda-java · GitHub
[go: up one dir, main page]
Skip to content

chore: Add 'v2' branch to build workflows #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2023
Merged

chore: Add 'v2' branch to build workflows #1341

merged 1 commit into from
Aug 4, 2023

Conversation

scottgerring
Copy link
Contributor

Issue #, if available:
#1337

Description of changes:

The v2 branch should build as part of the various build workflows, so that when we PR into it, we can treat it like another 'main'.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sonarqubecloud
Copy link
sonarqubecloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@scottgerring scottgerring marked this pull request as ready for review August 3, 2023 19:12
@scottgerring scottgerring requested a review from jeromevdl August 3, 2023 19:12
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (4fa74d1) 79.06% compared to head (f218a36) 79.06%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #1341   +/-   ##
=========================================
  Coverage     79.06%   79.06%           
  Complexity      651      651           
=========================================
  Files            74       74           
  Lines          2489     2489           
  Branches        257      257           
=========================================
  Hits           1968     1968           
  Misses          441      441           
  Partials         80       80

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jeromevdl
jeromevdl approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor
@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for me!

@scottgerring scottgerring merged commit 788d2ce into main Aug 4, 2023
@scottgerring scottgerring deleted the add-v2-to-workflow branch August 4, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromevdl jeromevdl jeromevdl approved these changes

Assignees
No one assigned
Labels
maintenance size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottgerring @codecov-commenter @jeromevdl
0