fix(docker): get container logs even on error #214
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddejong
reviewed
Nov 4, 2022
ericzbeard
approved these changes
Nov 4, 2022
|
That is correct. If the container exits with an error the container would not be removed so further investigation can be carried out. |
ericzbeard
approved these changes
Nov 4, 2022
ericzbeard
reviewed
Nov 4, 2022
kddejong
reviewed
Nov 4, 2022
ammokhov
approved these changes
Nov 8, 2022
kddejong
reviewed
Nov 8, 2022
There was a problem hiding this comment.
Is this process wrapped in the same process that prevents cancelling it?
Also I think at its current version @ericzbeard is correct this won't capture the error he is talking about.
|
I'm still super torn on this PR. I prefer |
…Windows (aws-cloudformation#208) * When on windows will not use os.geteuid() but root:root, also if call fails it will add warning message * Change test for docker no euid to work on Windows
…ws-cloudformation#209) Unpin importlib in bandit pre-commit config This reverts commit 768eed6.
…multi-os (aws-cloudformation#215) * Update github actions to latest version and test on all branches/PR * Added default line ending to LF on git checkout * Remove Python 3.10 from testing, fails for macos and windows * added precommit caching and pip caching * Add noop CI job for requirements
|
Let me clean up this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #211
On docker container error
auto_remove=Truewould not return container output. Switched toremove=Trueindocker.client.containers.runfor slightly less robust container removal but much better logging.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.