fix: Upgrade aws-encryption-sdk dependency #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshayrane
approved these changes
Apr 26, 2022
|
Do we also want to bump |
|
@darrylabbate Thanks for pointing that out, have updated the PR to upgrade the aws-encryption-sdk instead as there is no breaking change between v2 and v3 besides Python 2 support ending which does not apply here |
shri-tambe
approved these changes
Apr 27, 2022
wkexiang
approved these changes
Apr 27, 2022
kddejong
pushed a commit
to kddejong/cloudformation-cli-python-plugin
that referenced
this pull request
Oct 13, 2022
* fix: Upgrade aws-encryption-sdk dependency
kddejong
pushed a commit
to kddejong/cloudformation-cli-python-plugin
that referenced
this pull request
Oct 13, 2022
* fix: Upgrade aws-encryption-sdk dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The
cloudformation-cli-python-libhas a dependency on theaws-encryption-sdkfor python. The encryption SDK itself has a dependency on the pythoncryptographylibrary.Have had some reports on
HOOKtype handler returning this internal error:According the change log, version 37.0.0 was recently release and includes some breaking changes.
I have tested using the previous v36 version and the issue is fixed.
Adding cyrptography version less than v37 as a requirement for the CFN CLI Python library.Decided to upgrade the
aws-encryption-sdkto v3.1.0 instead based on @darrylabbate suggestion. Have tested this change as well.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.