improve anonymization for accountId #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: acc2388 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Amplifiyer
previously approved these changes
Feb 19, 2025
| @@ -24,7 +24,7 @@ export class AccountIdFetcher { | |||
| new GetCallerIdentityCommand({}) | |||
| ); | |||
| if (stsResponse && stsResponse.Account) { | |||
| const accountIdBucket = Number(stsResponse.Account) / 100; | |||
| const accountIdBucket = stsResponse.Account.slice(0, -2); | |||
| this.accountId = uuidV5( | |||
| accountIdBucket.toString(), | |||
There was a problem hiding this comment.
nit:
Suggested change
| accountIdBucket.toString(), | |
| accountIdBucket, |
There was a problem hiding this comment.
whoops, forgot to remove that
8000
sobolk
previously approved these changes
Feb 19, 2025
Amplifiyer
approved these changes
Feb 19, 2025
sobolk
approved these changes
Feb 19, 2025
blakedunson
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Follow up for #2519.
Improve anonymization for accountId in response to aws-amplify/amplify-cli#14113 (comment).
Corresponding docs PR, if applicable:
Validation
Added unit test to make sure accountIds fall into different buckets.
Checklist
run-e2elabel set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.