fix: remove DataFrame assert from unrelated test #1893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
metrizable
approved these changes
Sep 15, 2020
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
guoqiao1992
pushed a commit
to guoqiao1992/sagemaker-python-sdk
that referenced
this pull request
Oct 26, 2020
rsareddy0329
added a commit
that referenced
this pull request
Dec 3, 2025
* sagemaker-core update, port sft-trainer and ai registry (#1895) * sagemaker core update with MC service.json, SFT notebook flow succeeded before modelpackage * remove workaround, modelpackage issue persists * remove ai registry port * feat: AIRegistry SDK Implementation (#1893) * remove sft trainer port, fix ModelPackage issue (#1901) * Add/port finetuning interfaces to v3 (#1906) * Add/port finetuning interfaces to v3 * Add/port finetuning interfaces to v3 --------- Co-authored-by: Roja Reddy Sareddy <rsareddy@amazon.com> * ported evaluation from v2->v3. pending example notebooks results (#1902) * v2->v3 porting for eval * bring back deleted needed files * unit tests --------- Co-authored-by: Mohamed Zeidan <zeidmo@amazon.com> * Mc deployment (#1909) * Updates for Model Customization * Model Builder Base change * Fix * Support for Model Customization * New Model Builder changes with Model Customization * Fix * Add base_trainer, addition to PR#1906 (#1910) * Add/port finetuning interfaces to v3 * Add/port finetuning interfaces to v3 * Add base_trainer, addition to PR#1906 --------- Co-authored-by: Roja Reddy Sareddy <rsareddy@amazon.com> * AIRegistry Integration Tests (#1908) * feat: Trainer wait with MLFlow metrics (#1907) * feat: update eval integs (#1912) Co-authored-by: Mufaddal Rohawala <mufi@amazon.com> * Update get_all method for Evaluator and Dataset (#1913) * Update get_all method for Evaluator and Dataset - Update Dataset.get_all() and added refresh() - Update Evaluator.get_all() and added refresh() - Added more tags in condition when importing hub content * Update dataset, evaluators and examples * remove hub_content_name * port bedrock model builder and add integ test (#1911) * port bedrock model builder and add integ test * Add unit test and notebook, port new version of bedrock model builder * add docstring * Mc deployment integ tests and example notebook (#1914) * Updates for Model Customization * Model Builder Base change * Fix * Support for Model Customization * New Model Builder changes with Model Customization * Fix * Deployment Integ tests * Tests * Deployment NOtebook * fix * Update model hub name and encoding method (#1918) * Update get_all method for Evaluator and Dataset - Update Dataset.get_all() and added refresh() - Update Evaluator.get_all() and added refresh() - Added more tags in condition when importing hub content * Update dataset, evaluators and examples * remove hub_content_name * Update hub name and hash - Update model hub name to be AIRegistry-{accountId}-{region} - Update hub name hash * Add telemetry for model customization (#1920) * add telemetry to model customization * add telemetry to model customization 2 * small fix * INteg tests for nova bedrock (#1926) * Bedrock Nova * Unit tests for bedrock nova * accept eula always (#1928) Co-authored-by: Mohamed Zeidan <zeidmo@amazon.com> * Add studio tags to trainer (#1927) * Update get_all method for Evaluator and Dataset - Update Dataset.get_all() and added refresh() - Update Evaluator.get_all() and added refresh() - Added more tags in condition when importing hub content * Update dataset, evaluators and examples * remove hub_content_name * Update hub name and hash - Update model hub name to be AIRegistry-{accountId}-{region} - Update hub name hash * Add studio tags to trainer Tested nu checking training job creation inputs and unit tests --------- Co-authored-by: rsareddy0329 <rsareddy0329@gmail.com> * Finetuning classes: add accept_eula support & Add integ tests for sft, rlvr,rlaif, dpo trainers (#1915) * Add/port finetuning interfaces to v3 * Add/port finetuning interfaces to v3 * Add base_trainer, addition to PR#1906 * Add integ tests for sft, rlvr,rlaif, dpo trainers * Add integ tests for sft, rlvr,rlaif, dpo trainers * Finetuning classes: Add accept_eula support * Finetuning classes: Add accept_eula support --------- Co-authored-by: Roja Reddy Sareddy <rsareddy@amazon.com> * feat: pipeline name fix + mlflow arn fix + jinja dep (#1931) * changes for pipeline naming * feat: pipeline name fix + mlflow arn fix + jinja dep --------- Co-authored-by: Mufaddal Rohawala <mufi@amazon.com> * AIRegistry: Add Support to user provided session and role (#1932) * Add/port finetuning interfaces to v3 * Add/port finetuning interfaces to v3 * Add base_trainer, addition to PR#1906 * Add integ tests for sft, rlvr,rlaif, dpo trainers * Add integ tests for sft, rlvr,rlaif, dpo trainers * Finetuning classes: Add accept_eula support * Finetuning classes: Add accept_eula support * AIRegistry: Support user provided session and role * AIRegistry: Support user provided session and role * AIRegistry: Support user provided session and role --------- Co-authored-by: Roja Reddy Sareddy <rsareddy@amazon.com> * format name for ai reg, stripped name of =, added domain-id tags for … (#1930) * format name for ai reg, stripped name of =, added domain-id tags for datasets and evaluators, prefix changed t use full path including filename * pulling metadata path since get_current_domain_id didnt work * rmvd gamma endpoint --------- Co-authored-by: Mohamed Zeidan <zeidmo@amazon.com> * fixed train unit tests (#1933) Co-authored-by: Mohamed Zeidan <zeidmo@amazon.com> * Updating DataSet versioning pattern for parity with UI (#1934) * fix dataset arn configuration in eval (#1935) Co-authored-by: Mufaddal Rohawala <mufi@amazon.com> * Master model customization v3 (#1936) * Updating DataSet versioning pattern for parity with UI * Updating default S3 bucket and prefix for datasets * fix: custom metrics and pipeline name in lineage (#1937) * remove mlflow config for base model eval only * fix unit * fix custom metrics and pipeline name in lineage --------- Testing: 1. Added/Ran units. 2. Tested LLMAJ eval. Co-authored-by: Mufaddal Rohawala <mufi@amazon.com> * Integ tests for ModelBuilder (#1939) * Bedrock Nova * Unit tests for bedrock nova * Integ test updates * Test case updates * fixing AIRegistry integration and unit tests (#1941) * Update error messages based on feedback (#1938) * feat: Inline MLFlow metrics with Serverless MLFlow App (#1942) * Master model customization v3 (#1945) * Bedrock Nova * Unit tests for bedrock nova * Integ test updates * Test case updates * Bedrock tests * fix: update eval integ tests (#1946) * update eval integ tests * fix unit tests --------- Co-authored-by: Mufaddal Rohawala <mufi@amazon.com> * Finetuning classes: Add integ tests (#1947) * Add/port finetuning interfaces to v3 * Add/port finetuning interfaces to v3 * Add base_trainer, addition to PR#1906 * Add integ tests for sft, rlvr,rlaif, dpo trainers * Add integ tests for sft, rlvr,rlaif, dpo trainers * Finetuning classes: Add accept_eula support * Finetuning classes: Add accept_eula support * AIRegistry: Support user provided session and role * AIRegistry: Support user provided session and role * AIRegistry: Support user provided session and role * Finetuning classes: Add integration tests * Merge conflicts * Merge conflicts --------- Co-authored-by: Roja Reddy Sareddy <rsareddy@amazon.com> * Workflow change to enable github actions (#1948) * workflow change and test * remove test * Remove beta endpoint info, add region validation and tests (#1950) * Add/port finetuning interfaces to v3 * Add/port finetuning interfaces to v3 * Add base_trainer, addition to PR#1906 * Add integ tests for sft, rlvr,rlaif, dpo trainers * Add integ tests for sft, rlvr,rlaif, dpo trainers * Finetuning classes: Add accept_eula support * Finetuning classes: Add accept_eula support * AIRegistry: Support user provided session and role * AIRegistry: Support user provided session and role * AIRegistry: Support user provided session and role * Finetuning classes: Add integration tests * Merge conflicts * Merge conflicts * Remove beta endpoint details in sagemaker-core * add region validation for models --------- Co-authored-by: Roja Reddy Sareddy <rsareddy@amazon.com> --------- Co-authored-by: Molly He <mollyhe@amazon.com> Co-authored-by: jam-jee <jamjee@amazon.com> Co-authored-by: rsareddy0329 <rsareddy0329@gmail.com> Co-authored-by: Roja Reddy Sareddy <rsareddy@amazon.com> Co-authored-by: Mohamed Zeidan <zeidmo@amazon.com> Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com> Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com> Co-authored-by: Mufaddal Rohawala <mufi@amazon.com> Co-authored-by: Zhaoqi <52220743+zhaoqizqwang@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
training_job_analyticsgives empty DataFrame. TrainingJob does not seem to be emitting metrics to cloudwatch.Also this assertion seems to be unrelated to the test itself.
Description of changes:
Remove DataFrame assertion from the test.
We need to add independent integ test for
training_job_analytics.Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.