chore: update mainline-1.x with new release process #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebuild/release/version.yml
Outdated
| - git checkout $BRANCH | ||
| build: | ||
| commands: | ||
| - npx semantic-release --branches mainline-1.x --no-ci |
There was a problem hiding this comment.
I'm okay with this for now as a first step to get mainline-1.x more in line with mainline, but this is one of the places where we should parameterize the builds with branch name so that we don't have to maintain a separate build file in each branch.
|
While we're at it can we update the CI buildspec file on this branch as well? Currently CI fails to run on these PRs because it's not finding the |
| echo "pom.xml version (${FOUND_VERSION}) does not match expected version (${VERSION}), stopping" | ||
| exit 1; | ||
| fi | ||
| - export VERSION=$(grep version pom.xml | head -n 1 | sed -n 's/[ \t]*<version>\(.*\)<\/version>/\1/p') |
There was a problem hiding this comment.
I think this (and release-staging.yml) also need to checkout the right branch.
|
|
||
| env: | ||
| variables: | ||
| BRANCH: "master" |
There was a problem hiding this comment.
Suggested change
| BRANCH: "master" | |
| BRANCH: "mainline-1.x" |
farleyb-amazon
approved these changes
Oct 27, 2021
aws-crypto-tools-ci-bot
pushed a commit
that referenced
this pull request
Oct 28, 2021
### [1.9.1](v1.9.0...v1.9.1) (2021-10-28) ### Fixes * "AWS Encryption SDK 1.9.1 Release" ([#389](#389)) ([f58051d](f58051d)) ### Maintenance * Add back removed CiphertextHeaders.deserialize method ([#383](#383)) ([468625d](468625d)) * add corretto11 ([#390](#390)) ([f3140a7](f3140a7)) * CI formatting ([#388](#388)) ([129c2c0](129c2c0)) * update mainline-1.x with new release process ([#385](#385)) ([c55c2d2](c55c2d2))
aws-crypto-tools-ci-bot
pushed a commit
that referenced
this pull request
Oct 28, 2021
### [1.9.1](v1.9.0...v1.9.1) (2021-10-28) ### Fixes * "AWS Encryption SDK 1.9.1 Release" ([#389](#389)) ([f58051d](f58051d)) * "AWS Encryption SDK 1.9.1 Release" ([#391](#391)) ([cacee86](cacee86)) ### Maintenance * Add back removed CiphertextHeaders.deserialize method ([#383](#383)) ([468625d](468625d)) * add corretto11 ([#390](#390)) ([f3140a7](f3140a7)) * CI formatting ([#388](#388)) ([129c2c0](129c2c0)) * fix typo ([#392](#392)) ([f1f8d9f](f1f8d9f)) * update mainline-1.x with new release process ([#385](#385)) ([c55c2d2](c55c2d2))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds release updates to the mainline-1.x branch.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: