Prefer to upload files under version control #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (versionedFiles == 0) { | ||
| Log.error(sourceDirs.toString()); | ||
| Log.error(config.getVersionedFiles().toString()); | ||
| throw new GuruCliException(ErrorCodes.GIT_EMPTY_DIFF, |
There was a problem hiding this comment.
Should this be an exception or just a logged warning?
Contributor
Author
There was a problem hiding this comment.
This should end the workflow because there's no point sending anything to CodeGuru and it was probably a mistake. These exceptions don't show stacktraces, they just lead to an error message that aborts the upload and scan.
|
|
||
|
|
||
| @Test | ||
| public void test_zipAndUpload_happyCaseGitFilesOnly() throws Exception { |
There was a problem hiding this comment.
Is there a test case that covers the case when the option "scan only version controlled files" is not set?
Contributor
Author
There was a problem hiding this comment.
Good point. Let me add one.
There was a problem hiding this comment.
Looks good overall, some comments/questions.
senguptaaritra
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#7
Description of changes:
When scanning a directory that is under version control, the cli should ask if all files should be analyzed or only files that are under version control.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.