Avoid array allocations from GetDirectories/GetFiles. (PowerShell#15167)

xtqqczze · web-flow · commit 4e073fdd3ffb · 2021-04-15T08:16:26.000+05:00
diff --git a/src/System.Management.Automation/help/HelpFileHelpProvider.cs b/src/System.Management.Automation/help/HelpFileHelpProvider.cs
@@ -368,7 +368,7 @@ internal Collection<string> GetExtendedSearchPaths()
                     {
                         // Get all the directories under the module path
                         // * and SearchOption.AllDirectories gets all the version directories.
-                        string[] directories = Directory.GetDirectories(psModulePath, "*", SearchOption.AllDirectories);
+                        IEnumerable<string> directories = Directory.EnumerateDirectories(psModulePath, "*", SearchOption.AllDirectories);
 
                         var possibleModuleDirectories = directories.Where(static directory => !ModuleUtils.IsPossibleResourceDirectory(directory));
 

Original file line number	Diff line number	Diff line change
`@@ -368,7 +368,7 @@ internal Collection<string> GetExtendedSearchPaths()`
`368`	`368`	`{`
`369`	`369`	`// Get all the directories under the module path`
`370`	`370`	`// * and SearchOption.AllDirectories gets all the version directories.`
`371`		`- string[] directories = Directory.GetDirectories(psModulePath, "*", SearchOption.AllDirectories);`
	`371`	`+ IEnumerable<string> directories = Directory.EnumerateDirectories(psModulePath, "*", SearchOption.AllDirectories);`
`372`	`372`
`373`	`373`	`var possibleModuleDirectories = directories.Where(static directory => !ModuleUtils.IsPossibleResourceDirectory(directory));`
`374`	`374`