8000 Replace `GetDirectories` in `HelpFileHelpProvider` by xtqqczze · Pull Request #15167 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Replace GetDirectories in HelpFileHelpProvider #15167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2021
Merged

Replace GetDirectories in HelpFileHelpProvider #15167

merged 1 commit into from
Apr 15, 2021

Conversation

xtqqczze
Copy link
Contributor
@xtqqczze xtqqczze commented Apr 6, 2021

Avoid array allocations from GetDirectories/GetFiles.

Contributes to #14318.

@ghost ghost assigned iSazonov Apr 6, 2021
8000 @xtqqczze xtqqczze closed this Apr 6, 2021
@xtqqczze xtqqczze reopened this Apr 6, 2021
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Apr 6, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label Apr 14, 2021
@ghost
Copy link
ghost commented Apr 14, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze
Copy link
Contributor Author

@iSazonov Shall I replace Linq Where with if statement?

@iSazonov
Copy link
Collaborator

No. If @adityapatwardhan agree I will merge.

@ghost ghost removed the Review - Needed The PR is being reviewed label Apr 14, 2021
@iSazonov iSazonov merged commit 4e073fd into PowerShell:master Apr 15, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.6 milestone Apr 15, 2021
@xtqqczze xtqqczze deleted the getfiles-HelpFileHelpProvider branch April 15, 2021 14:49
@ghost
Copy link
ghost commented May 27, 2021

🎉v7.2.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan left review comments

@iSazonov iSazonov iSazonov approved these changes

Assignees

@iSazonov iSazonov

Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
None yet
Milestone
7.2.0-preview.6
Development

Successfully merging this pull request may close these issues.
3 participants
@xtqqczze @iSazonov @adityapatwardhan
0