Fixed Linux bug where a stat object was returned instead of a binary … #64
Conversation
|
@nabil1337 I'm wondering if you've tried this recently? Can't seem to get this or your fork to work on the latest Electron at the moment. (Ubuntu 18.04) |
|
@Muffinman yeah, still worked for me with electron 4. But I cannot test it with v5, because of some other failing dependencies in my only project using it. Can you create a minimal test case (like a fiddle, not a unit test) showing how it fails? I'm using this code (obfuscated it a bit, it also relies on webpack): const sudoerModule = await import('electron-sudo');
const Sudoer = sudoerModule.default;
const sudoer = new Sudoer({name: 'my-app'});
const workerPath = getWorkerPath();
const child = await sudoer.spawn('node', [workerPath]);
child.stdout.on('data', buffer => console.log('[my-process] '
+ buffer.toString()));
child.stderr.on('data', buffer => console.log('[my-process/err] '
+ buffer.toString()));
return child;This should also work without dynamic import and just plain old |
|
Thanks for the reply, I've since found a related issue on the Electron issue tracker. It seems to be specific to v5.0.0+ where no setuid binaries can currently be called at all on any linux builds. Hopefully they fix this soon. |
…path.
Hey, this makes your lib run on my Linux machine. :)
While tests fail, this has also been the case before I did any changes. So I suggest you counter check it first and then merge, if you feel like doing so.
#61 #41 #53