8000 feat: add RelyingPartyIdentifier field to CustomDomain by ramya18101 · Pull Request #686 · auth0/go-auth0 · GitHub
[go: up one dir, main page]

Skip to content

feat: add RelyingPartyIdentifier field to CustomDomain#686

Merged
developerkunal merged 2 commits intov1from
DXSDK-7476-rpID-support-for-custom-domains
Jan 28, 2026
Merged

feat: add RelyingPartyIdentifier field to CustomDomain#686
developerkunal merged 2 commits intov1from
DXSDK-7476-rpID-support-for-custom-domains

Conversation

@ramya18101
Copy link
Contributor
@ramya18101 ramya18101 commented Jan 27, 2026

🔧 Changes

  • Introduced the RelyingPartyIdentifier field to the CustomDomain struct.
  • Updated relevant methods and functions to incorporate this new field.

📚 References

https://auth0.com/docs/api/management/v2/custom-domains/get-custom-domains
https://auth0.com/docs/api/management/v2/custom-domains/patch-custom-domains-by-id

🔬 Testing

Added unit tests to ensure appropriate coverage for the new functionality.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link
codecov-commenter commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.69%. Comparing base (09688a4) to head (eebf1ed).

Additional details and impacted files
@@           Coverage Diff           @@
##               v1     #686   +/-   ##
=======================================
  Coverage   96.69%   96.69%           
=======================================
  Files          62       62           
  Lines       10740    10744    +4     
=======================================
+ Hits        10385    10389    +4     
  Misses        236      236           
  Partials      119      119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ramya18101 ramya18101 marked this pull request as ready for review January 27, 2026 08:45
@ramya18101 ramya18101 requested a review from a team as a code owner January 27, 2026 08:45
@ramya18101 ramya18101 force-pushed the DXSDK-7476-rpID-support-for-custom-domains branch from abf2d3c to ba3bf3a Compare January 28, 2026 07:59
@ramya18101 ramya18101 force-pushed the DXSDK-7476-rpID-support-for-custom-domains branch from ba3bf3a to eebf1ed Compare January 28, 2026 08:04
Copy link
Contributor
@developerkunal developerkunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@developerkunal developerkunal merged commit c34a45f into v1 Jan 28, 2026
4 checks passed
@developerkunal developerkunal deleted the DXSDK-7476-rpID-support-for-custom-domains branch January 28, 2026 08:46
@developerkunal developerkunal mentioned this pull request Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0