remove warning for untyped requests#385
Merged
jimmyjames merged 1 commit intoauth0:masterfrom Dec 2, 2021
Merged
Conversation
jimmyjames
approved these changes
Dec 2, 2021
Contributor
There was a problem hiding this comment.
🎉 nice work! Thanks for this contribution!!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Please describe both what is changing and why this is important. Include:
I Added specific typing for void requests. This is important because first, IDEs usually give warnings when an object's type is not specified. It does not do anything at runtime because of type-erasure, but it makes it impossible for the IDE to know what is supposed to come out of that object.
This causes a small inconvenience when using the library. In my case, I wrapped the auth0 library with custom code that handles Rate-limiting better and automatically execute requests, which is why the dynamic typing is needed.
I was therefore forced to specify myself the
Anytype (because the library doesn't specify theVoid)Testing
Does not impact tests. It just removes warnings.
Checklist