PART-548 | Give RICH_TEXT a distinct enum value so STRING and RICH_TEXT are not aliases#857
Open
Aryamanz29 wants to merge 3 commits intomainfrom
Open
PART-548 | Give RICH_TEXT a distinct enum value so STRING and RICH_TEXT are not aliases#857Aryamanz29 wants to merge 3 commits intomainfrom
Aryamanz29 wants to merge 3 commits intomainfrom
Conversation
… not aliases
STRING and RICH_TEXT shared the same enum value ("string"), making them
indistinguishable in Python's Enum. This caused STRING attributes to
incorrectly get is_rich_text=True and RICH_TEXT multi-value restrictions
to apply to STRING.
Fixes PART-548
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The test file imported pyatlan_v9, which transitively pulled all of pyatlan_v9 into mypy's scope when checking `pyatlan tests`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.