breaking(tests): mutation responses are now sparse#2316
Merged
Conversation
… response The mutation response from removeCertificate() / removeAnnouncement() no longer returns fields unrelated to the specific mutation (e.g. announcement fields are absent after a certificate removal). Refactor all affected updateXxxAgain / removeCategoryAttributes test methods to call .get() on the asset by GUID after each mutation so assertions are made against actual server state rather than the sparse mutation response. Affects 16 integration test classes across ADLSAssetTest, AirflowAssetTest, APIAssetTest, AppAssetTest, AnaplanAssetTest, AzureEventHubTest, CubeTest, DataStudioAssetTest, FileTest, GCSAssetTest, GlossaryTest, InsightsTest, KafkaTest, PresetAssetTest, S3AssetTest, and SupersetAssetTest. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Chris (He/Him) <cgrote@gmail.com>
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
- cube-assets-builder: default cubeSubFieldCount to 0L for leaf CubeFields that have no children in qualifiedNameToChildCount map - admin-export: guard group-related assertions so they only run when the user actually belongs to groups, avoiding false failures for groupless users Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Chris (He/Him) <cgrote@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Atlan backend API changed such that mutation responses (e.g.
removeCertificate(),removeAnnouncement()) are now sparse — they only return fields directly related to the specific mutation. Previously, aremoveCertificate()call would return the full asset state including announcement fields; it no longer does.This PR refactors all affected integration tests to call
.get()on the asset by GUID immediately after each mutation, asserting against the actual server state rather than the now-incomplete mutation response.Affected test classes (16):
ADLSAssetTest,APIAssetTest,AirflowAssetTest,AnaplanAssetTest,AppAssetTest,AzureEventHubTest,CubeTest,DataStudioAssetTest,FileTest,GCSAssetTest,GlossaryTest,InsightsTest,KafkaTest,PresetAssetTest,S3AssetTest,SupersetAssetTestAlso includes:
gradle/libs.versions.toml)atlanhq/modelsTest plan
./gradlew test -PintegrationTests)./gradlew test)🤖 Generated with Claude Code