Conversation
Signed-off-by: Chris (He/Him) <cgrote@gmail.com>
Signed-off-by: Chris (He/Him) <cgrote@gmail.com>
There was a problem hiding this comment.
Bug: CSV Export: Unwanted Empty Files
When using CSV format, all five CSV files are unconditionally added to fileOutputs, regardless of which objects are specified in ctx.config.objectsToInclude. This causes empty CSV files to be sent via email or uploaded to cloud storage for objects that weren't requested for export.
samples/packages/admin-export/src/main/kotlin/com/atlan/pkg/ae/AdminExporter.kt#L98-L99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Ensures admin-export touches default-named files even when custom filenames are used, adds term/column link helpers, and updates several dependencies.
admin-export.xlsx,users.csv,groups.csv,personas.csv,purposes.csv,policies.csv) alongside user-provided filenames to avoid workflow failures.getTermLink(client, guid)forglossaryURLs.getColumnLink(client, tableGuid, guid)to deep-link directly to a column via?column=.wiremock->3.13.2,awssdk->2.38.7,poi->5.5.0,commons-lang->3.20.0,openlineage->1.40.1,jetty->12.1.4.Written by Cursor Bugbot for commit d89e5d8. This will update automatically on new commits. Configure here.