feat: create Accordion component and its stories #3121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3121--asyncapi-website.netlify.app/ |
akshatnema
requested changes
Jul 29, 2024
|
|
||
| type Story = StoryObj<typeof Accordion>; | ||
|
|
||
| const sampleAccordionItemList = [ |
There was a problem hiding this comment.
Make sure that this list is of AccordionItemType items only. Specify the AccordionItemType type for this variable.
akshatnema
requested changes
Aug 24, 2024
components/Accordion/Accordion.tsx
Outdated
| accordionItems: AccordionItemType[]; | ||
| } | ||
|
|
||
| const Accordion = ({ accordionItems = [] }: AccordionProps) => { |
There was a problem hiding this comment.
use export default function here and create a JSdoc above this function to describe the component.
| setActiveIndex: (index: number | null) => void; | ||
| } | ||
|
|
||
| const AccordionItem = ({ itemIndex, title, content, isActive, setActiveIndex }: AccordionItemProps) => { |
components/faq/FAQ.tsx
Outdated
Comment on lines
10
to
12
| <div> | ||
| <Accordion accordionItems={faqList} /> | ||
| </div> |
There was a problem hiding this comment.
Suggested change
| <div> | |
| <Accordion accordionItems={faqList} /> | |
| </div> | |
| <Accordion accordionItems={faqList} /> |
No need to wrap this under a div.
components/faq/FAQ.tsx
Outdated
| import { faqList } from './FAQList'; | ||
|
|
||
| /** | ||
| * This is the FAQ component. It tells the user about the frequently asked questions. |
There was a problem hiding this comment.
Specify that this component has been created to render FAQ list inside MDX file.
components/faq/FAQ.tsx
Outdated
| /** | ||
| * This is the FAQ component. It tells the user about the frequently asked questions. | ||
| */ | ||
| const FAQ = () => { |
There was a problem hiding this comment.
Use export default function here.
akshatnema
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created an accordion component, added stories for it, and used it in the FAQ section.