8000 Preserve underscore when renaming field by simonvandel · Pull Request #1706 · async-graphql/async-graphql · GitHub
[go: up one dir, main page]

Skip to content

Preserve underscore when renaming field #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

simonvandel
Copy link

Fixes #1698

I had to change a bunch of places that relied on variable names with underscores not being preserved.

So technically I think this is a breaking change - but I also think it was a bug to not preserve the underscore.

What do you think?

Fixes async-graphql#1698

I had to change a bunch of places that relied on variable names with
underscores not being preserved.

So technically I think this is a breaking change - but I also think it
was a bug to not preserve the underscore.

What do you think?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interface with field starting with underscore generates SDL name without underscore
1 participant
0