8000 MAINT: some generic cleanups by bsipocz · Pull Request #206 · astropy/sphinx-automodapi · GitHub
[go: up one dir, main page]
Skip to content

MAINT: some generic cleanups #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2025
Merged

MAINT: some generic cleanups #206

merged 2 commits into from
Apr 17, 2025

Conversation

bsipocz
Copy link
Member
@bsipocz bsipocz commented Apr 16, 2025
  • one to get cleaner release notes
  • one to sort out name duplicates for contributors

@bsipocz bsipocz added this to the 0.19.0 milestone Apr 16, 2025
@bsipocz bsipocz requested a review from pllim April 16, 2025 17:58
@codecov Codecov
Copy link
codecov bot commented Apr 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.05%. Comparing base (09aeffb) to head (5a5d9ce).
Report is 11 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #206   +/-   ##
=======================================
  Coverage   90.05%   90.05%           
=======================================
  Files          31       31           
  Lines        1227     1227           
=======================================
  Hits         1105     1105           
  Misses        122      122

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pllim
pllim reviewed Apr 17, 2025
View reviewed changes
.github/release.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for? Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean... where is this setting actually used? Just curious.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used when you auto generate release notes from the tag on GitHub.

Someone pointed it out in the changelog spec discussion that they use this for tox and I would love to try it out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made two screenshots for this using the new release tag v0.19.0 and a test tag for the commit before this merge:

Screenshot 2025-04-17 at 13 55 36

Screenshot 2025-04-17 at 13 55 28

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's cool! TIL. Thanks!

@bsipocz bsipocz merged commit fac5a71 into astropy:main Apr 17, 2025
20 checks passed
@bsipocz bsipocz deleted the MAINT_bot_cleanup branch April 17, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pllim pllim pllim left review comments

Assignees
No one assigned
Labels
no-changelog-entry-needed
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bsipocz @pllim
0