8000 Add dot to extensions of added MIME types by hugovk · Pull Request #622 · astropy/pyvo · GitHub
[go: up one dir, main page]

Skip to content

Add dot to extensions of added MIME types #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

hugovk
Copy link
Contributor
@hugovk hugovk commented Nov 21, 2024

There's a suggestion in python/cpython#75223 / python/cpython#2895 to raise a ValueError when adding MIME type extensions with a dot.

This PR adds the dots.

Copy link
codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.31%. Comparing base (f9211e3) to head (c4080f7).
Report is 58 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #622   +/-   ##
=======================================
  Coverage   82.31%   82.31%           
=======================================
  Files          72       72           
  Lines        7431     7431           
=======================================
  Hits         6117     6117           
  Misses       1314     1314           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member
@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, it looks uncontroversial, so I go ahead with a merge.

@bsipocz bsipocz merged commit 99e0fd9 into astropy:main Nov 21, 2024
13 of 14 checks passed
@hugovk hugovk deleted the v-mimetypes.add_type-with-dot branch November 21, 2024 16:51
bsipocz added a commit that referenced this pull request Feb 13, 2025
Add dot to extensions of added MIME types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0