This repository was archived by the owner on Oct 17, 2024. It is now read-only.
MNT: Use C99 to compile numpy-dev #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
|
Unfortunately, this does not seem to work. Example log: https://travis-ci.org/astropy/astropy/jobs/475919446 (and also the CI for this PR has the same error)
|
|
Try |
|
Yay, tests passed! (Appveyor failure is unrelated.) |
|
I guess we can still nitpick on whether we want that CFLAGS defined for all Numpy selections, but at least the solution is at hand now. |
|
Nice. Anything except |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @rgommers (thank you! 🙏 ) over at numpy/numpy#12610 (comment)
I will open an experimental PR over as Astropy to use this branch and see what happens. 🤞
Fix astropy/astropy#8318