8000 specutils: Add Brigitta as maintainer because she already is in the team by pllim · Pull Request #548 · astropy/astropy.github.com · GitHub
[go: up one dir, main page]

Skip to content

specutils: Add Brigitta as maintainer because she already is in the team #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pllim
Copy link
Member
@pllim pllim commented Aug 23, 2023

I took the liberty to clean up specutils access by doing the following:

  • Removing individuals with Read/Triage/Write access (after consulting with Ricky) because they are either unnecessary, no longer active, or added without a good cause.
  • Removing astropy-contributors Team with Read access. Not sure what this is for. I didn't see it listed in specreduce.
  • Removing astropy-project-release-team. This team is for astropy release and it is not on the hook for Coordinated packages that are supposed to have their own maintainers.
  • Downgrading devops-maintainers from Admin to Maintain. I think the infrastructure is okay now, so DevOps does not need to be so involved now but I have no doubt the Admin access was needed at some point.
  • Retaining the existing Admin access for specutils-maintainers but sync it with the Team page (hence this PR). I recognize that every package gets maintained differently but if you find yourselves needing sub-team with Admin and not everyone here, I would be happy to help you set it up.

cc @keflavich @eteq @nmearl @bsipocz @rosteen

because she already is in the team
@bsipocz
Copy link
Member
bsipocz commented Aug 23, 2023

No need to add me, I don't have time or plans for specutils

@pllim
Copy link
Member Author
pllim commented Aug 23, 2023

@bsipocz , then should I remove you from the (GitHub) team? The team is already there, so I am just trying to sync things up. I can do it one way or the other. Please confirm. Thanks!

@bsipocz
Copy link
Member
bsipocz 8000 commented Aug 23, 2023

Btw, the release team was needed to be added here as historically specutils incompatibility with RC was a release blocker for astropy...

@pllim
Copy link
Member Author
pllim commented Aug 23, 2023

specutils incompatibility with RC was a release blocker for astropy

Hmm, good point, though that could happen to any of our downstream packages. We only have two release managers now and they both at limited capacity. I'll reconsider this if it happens again but hopefully not with better CI setup (we improved it recently), more active maintainers, and rudimentary https://github.com/astropy/astropy-integration-testing

@pllim
Copy link
Member Author
pllim commented Aug 23, 2023

As stated in #548 (comment) , I will close this without merge and sync the GitHub team accordingly. Thank you for your prompt response!

@pllim pllim closed this Aug 23, 2023
@pllim pllim deleted the specutils-maintainers branch August 23, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0