8000 specreduce: Add Kyle and Clare as maintainers because they already are by pllim · Pull Request #547 · astropy/astropy.github.com · GitHub
[go: up one dir, main page]
Skip to content

specreduce: Add Kyle and Clare as maintainers because they already are #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2023
Merged

specreduce: Add Kyle and Clare as maintainers because they already are #547

merged 1 commit into from
Oct 20, 2023

Conversation

pllim
Copy link
Member
@pllim pllim commented Aug 23, 2023

@kecnry and @cshanahan1 already have maintainer access to specreduce for a while as individuals and they are actively maintaining the package. I have taken the liberty to clean up specreduce and specreduce-data permissions by doing the following and this PR just making their existing jobs official.

  • Remove individuals with only Read access to specreduce. This is unnecessary because it is a public repo. If you want them to have access for triage, create a proper triage team. Refrain from providing arbitrary individual access.
  • Added Kyle and Clare to https://github.com/orgs/astropy/teams/specreduce-maintainers and downgrade that team's access from Admin to Maintain.
  • Created a new admin team with existing admins (@eteq and @tepickering) and give them back their existing access but under a new team name.

All in all, there are no changes to existing access. I am just making things official. I think it is nice to give people who are doing the work some credit officially.

@pllim
specreduce: Add Kyle and Clare 8000
0f21ef7 
as maintainers because they already are.
@pllim pllim requested a review from eteq August 23, 2023 15:50
@pllim pllim mentioned this pull request Aug 23, 2023
Open
47 tasks
@hamogu
Copy link
Member
hamogu commented Oct 20, 2023

Only approving comments on this and the two week comment period has run out, so I'm merging.

@hamogu hamogu merged commit f2b8e82 into astropy:main Oct 20, 2023
@pllim pllim deleted the specreduce-maintainers branch October 23, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eteq eteq Awaiting requested review from eteq

Assignees
No one assigned
Labels
roles and team
< 4771 /div>
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pllim @hamogu
0