8000 Roles: Add specreduce to Coordinated section by pllim · Pull Request #521 · astropy/astropy.github.com · GitHub
[go: up one dir, main page]

Skip to content

Roles: Add specreduce to Coordinated section #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2023

Conversation

pllim
Copy link
Member
@pllim pllim commented Mar 6, 2023

specreduce is listed as Coordinated under https://www.astropy.org/affiliated/index.html#coordinated-package-list but not listed in roles.json. Here, I simply copy over the "Maintainer(s)" listed over there to this JSON file. Whether they are really actively maintaining or not, I do not know. If this listing is no longer accurate, please tell me the current maintainers for specreduce. Thanks!

Affected people in the added listing:

@eteq
Copy link
Member
eteq commented Mar 20, 2023

In practice @kecnry has been doing some maintainer work as well I'd say.

However, @kecnry is not currently a maintainer in any astropy project role, nor @tepickering. perhaps we should first have this be just me in this PR, and then have a spearate PR to add @kecnry and @tepickering following the regular "add people" process? (I made that suggestion just below to facilitate this if you agree, @pllim)

{
"role": "specreduce",
"people": [
"Tim Pickering",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

< 8000 /form>
Suggested change
"Tim Pickering",

This comment was marked as outdated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for completeness, Tim is already on https://github.com/orgs/astropy/teams/specreduce-maintainers , so I don't see the problem.

If Kyle should be promoted to this role, please open a separate PR and we can go through the usual procedures for adding people. Thanks!

@hamogu
Copy link
Member
hamogu commented Mar 20, 2023

I think we can do that "add people" in the same PR and follow the regular process for this PR.

@hamogu hamogu merged commit 5866c2a into astropy:main May 3, 2023
@pllim pllim deleted the roles-add-specreduce branch May 4, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0