10000 Fix bug in init from list of mixins by taldcroft · Pull Request #9680 · astropy/astropy · GitHub
[go: up one dir, main page]
Skip to content

Fix bug in init from list of mixins #9680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2019
Merged

Fix bug in init from list of mixins #9680

merged 1 commit into from
Nov 26, 2019

Conversation

taldcroft
Copy link
Member

Description

There was an oversight in #9165 (Allow adding a table column as a list of mixin-type objects) where the column info.indices was not initialized to []. This whole machinery is little fragile, but for now just doing the initialization fixes the problem noted in #9357.

Fixes #9357

@taldcroft taldcroft added table Bug Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed labels Nov 25, 2019
@taldcroft taldcroft added this to the v4.0 milestone Nov 25, 2019
@taldcroft taldcroft mentioned this pull request Nov 25, 2019
Closed
@taldcroft taldcroft requested a review from mhvk November 25, 2019 22:33
mhvk
mhvk approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor
@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! One off the list of 4.0 blockers!

@mhvk
Copy link
Contributor
mhvk commented Nov 26, 2019

p.s. Agreed that the indices part seems a big fragile - I fear I don't quite understand it, but will try to make an effort at some point!

@mhvk mhvk merged commit 3bad8ff into astropy:master Nov 26, 2019
@taldcroft taldcroft deleted the table-fix-init-from-mixin-list branch November 26, 2019 10:52
bsipocz pushed a commit that referenced this pull request Dec 1, 2019
@mhvk @bsipocz
Merge pull request #9680 from taldcroft/table-fix-init-from-mixin-list
29b6df7 
Fix bug in init from list of mixins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhvk mhvk mhvk approved these changes

Assignees
No one assigned
Labels
Affects-dev PRs and issues that do not impact an existing Astropy release Bug no-changelog-entry-needed table
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.

group_by fails with a Time column
2 participants
@taldcroft @mhvk
0