8000 Don't log when passed unit matches FITS BUNIT by m4cd4r4 · Pull Request #19389 · astropy/astropy · GitHub
[go: up one dir, main page]
Skip to content

Don't log when passed unit matches FITS BUNIT#19389

Open
m4cd4r4 wants to merge 6 commits intoastropy:mainfrom
m4cd4r4:fix/ccddata-redundant-log
Open

Don't log when passed unit matches FITS BUNIT#19389
m4cd4r4 wants to merge 6 commits intoastropy:mainfrom
m4cd4r4:fix/ccddata-redundant-log

Conversation

@m4cd4r4
Copy link
@m4cd4r4 m4cd4r4 commented Mar 10, 2026

Description

Description

Don't log when passed unit matches FITS BUNIT

CCDData.read logs an info message whenever a unit argument is passed alongside a FITS file that has a BUNIT header, even when they match. This is noisy when users explicitly pass the unit to confirm what's already in the file.

The log now only fires when the two units actually differ.

Fixes #13539

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Contributor
github-actions bot commented Mar 10, 2026

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim added this to the v8.0.0 milestone Mar 10, 2026
@pllim
Copy link
Member
pllim commented Mar 10, 2026

Probably need regression test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

nddata

Projects

None yet

Milestone

v8.0.0

Development

Successfully merging this pull request may close these issues.

Avoid logger info in CCDData.read when unit specifies matches that in FITS file

2 participants

@m4cd4r4 @pllim
0