8000 TMP: test automodapi by Cadair · Pull Request #17919 · astropy/astropy · GitHub
[go: up one dir, main page]
Skip to content

TMP: test automodapi #17919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

TMP: test automodapi #17919

wants to merge 1 commit into from

Conversation

Cadair
Copy link
Member
@Cadair Cadair commented Mar 20, 2025 •
edited
Loading

@Cadair Cadair requested a review from WilliamJamieson March 20, 2025 14:43
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions GitHub Actions
Copy link
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim pllim added this to the v7.1.0 milestone Mar 20, 2025
@Cadair Cadair mentioned this pull request Mar 20, 2025
Merged
@Cadair Cadair changed the title TMP: test automodapi [ci skip] TMP: test automodapi Mar 20, 2025
@Cadair
Copy link
Member Author
Cadair commented Mar 20, 2025

The doc build should not be taking this long 🤔. It worked locally for me :(

@pllim
Copy link
Member
pllim commented Mar 20, 2025

I tried to kill it from RTD UI but didn't work. I think it is stuck. Are you able to amend a commit and push that out again to kick off another run, just in case it is transient?

@Cadair Cadair force-pushed the automodapi_properties branch from 4acd95d to 59b43a7 Compare March 20, 2025 16:43
@pllim pllim closed this Mar 21, 2025
@pllim
Copy link
Member
pllim commented Mar 21, 2025

PR under test was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliamJamieson WilliamJamieson Awaiting requested review from WilliamJamieson

Assignees
No one assigned
Labels
Experimental installation
Projects
None yet
Milestone
v7.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Cadair @pllim
0