8000 DOC: Build on py313 with sphinx-dev by pllim · Pull Request #17621 · astropy/astropy · GitHub
[go: up one dir, main page]
Skip to content

DOC: Build on py313 with sphinx-dev #17621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

DOC: Build on py313 with sphinx-dev #17621

wants to merge 2 commits into from

Conversation

pllim
Copy link
Member
@pllim pllim commented Jan 9, 2025

Description

This pull request is to investigate #17614

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim pllim added this to the v7.1.0 milestone Jan 9, 2025
@github-actions github-actions bot added the Docs label Jan 9, 2025
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jan 9, 2025

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jan 9, 2025

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim
Copy link
Member Author
pllim commented Jan 9, 2025 •
edited
Loading

Hmm with sphinx-dev, I see other warning and errors beside modeling.

Maybe I will rerun with stable Sphinx and see.

@pllim
Copy link
Member Author
pllim commented Jan 9, 2025

Sphinx does have a job for Python 3.13. 🧐 https://github.com/sphinx-doc/sphinx/blob/master/.github/workflows/main.yml

@pllim
Copy link
Member Author
pllim commented Jan 9, 2025 •
edited
Loading

With stable Sphinx

  • 'autodoc-before-process-signature' threw an exception (exception: list index out of range) [autodoc] (as Larry reported)
  • astropy/table/table.py:docstring of astropy.table.table.Table.pformat:3: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils] (and pformal_all)
  • astropy/config/paths.py:docstring of astropy.config.paths.get_cache_dir_path:1: WARNING: py:class reference target not found: pathlib._local.Path [ref.class] -- References to pathlib objects are incorrectly picked up by autodoc sphinx-doc/sphinx#13178

Unlike sphinx-dev, there is no patched_generate_dot error (let's not worry about that one for now).

@pllim pllim mentioned this pull request Jan 9, 2025
Closed
@pllim
Copy link
Member Author
pllim commented Jan 9, 2025

Cannot make sense of this yet...

@pllim pllim mentioned this pull request Jan 11, 2025
Closed
@AA-Turner AA-Turner mentioned this pull request Jan 23, 2025
Merged
@pllim
Copy link
Member Author
pllim commented Jan 24, 2025

Superseded by #17659

@pllim pllim closed this Jan 24, 2025
@pllim pllim marked this pull request as ready for review January 24, 2025 02:54
@pllim pllim deleted the py313-autodoc branch July 2, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Docs Experimental no-changelog-entry-needed
Projects
None yet
Milestone
v7.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@pllim
0