8000 Fix typos in quantity tests by larrybradley · Pull Request #17394 · astropy/astropy · GitHub
[go: up one dir, main page]
Skip to content

Fix typos in quantity tests#17394

Merged
pllim merged 1 commit intoastropy:mainfrom
larrybradley:fix-typos
Nov 14, 2024
Merged

Fix typos in quantity tests#17394
pllim merged 1 commit intoastropy:mainfrom
larrybradley:fix-typos

Conversation

@larrybradley
Copy link
Member
@larrybradley larrybradley commented Nov 14, 2024

Description

I'm late to the party, but this PR fixes a couple of typos introduced in #17354. I'm not sure if it's necessary to backport this.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@larrybradley larrybradley added this to the v6.1.7 milestone Nov 14, 2024
@github-actions
Copy link
Contributor
github-actions bot commented Nov 14, 2024

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

pllim
pllim approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member
@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not hurt to backport. Thanks!

@pllim pllim enabled auto-merge November 14, 2024 15:02
neutrinoceros
neutrinoceros approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor
@neutrinoceros neutrinoceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! I propose to backport anyway, if only to reduce the chance of a conflict down the line.

@neutrinoceros neutrinoceros modified the milestones: v6.1.7, v7.0.0 Nov 14, 2024
@pllim pllim merged commit 3bd8b40 into astropy:main Nov 14, 2024
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Nov 14, 2024
@pllim @meeseeksmachine
Backport PR astropy#17394: Fix typos in quantity tests
6c22fbe
@meeseeksmachine meeseeksmachine mentioned this pull request Nov 14, 2024
Merged
@pllim
Copy link
Member
pllim commented Nov 14, 2024

For the sake of consistency, let's do v6.1.x as well.

@meeseeksdev backport to v6.1.x

meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Nov 14, 2024
@pllim @meeseeksmachine
Backport PR astropy#17394: Fix typos in quantity tests
9444181
@meeseeksmachine meeseeksmachine mentioned this pull request Nov 14, 2024
Merged
@pllim pllim modified the milestones: v7.0.0, v6.1.7 Nov 14, 2024
pllim added a commit that referenced this pull request Nov 14, 2024
@pllim
Merge pull request #17395 from meeseeksmachine/auto-backport-of-pr-17…
f138c62 
…394-on-v7.0.x

Backport PR #17394 on branch v7.0.x (Fix typos in quantity tests)
pllim added a commit that referenced this pull request Nov 14, 2024
@pllim
Merge pull request #17396 from meeseeksmachine/auto-backport-of-pr-17…
99241d3 
…394-on-v6.1.x

Backport PR #17394 on branch v6.1.x (Fix typos in quantity tests)
@larrybradley larrybradley deleted the fix-typos branch November 14, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes

@neutrinoceros neutrinoceros neutrinoceros approved these changes

Assignees

No one assigned

Labels

Bug no-changelog-entry-needed testing units

Projects

None yet

Milestone

v6.1.7

Development

Successfully merging this pull request may close these issues.

3 participants

@larrybradley @pllim @neutrinoceros
0