8000 BUG: ensure nanvar(angle) drops to quantity (instead of raising) by mhvk · Pull Request #17239 · astropy/astropy · GitHub
[go: up one dir, main page]
Skip to content

BUG: ensure nanvar(angle) drops to quantity (instead of raising)#17239

Merged
mhvk merged 2 commits intoastropy:mainfrom
mhvk:angle-drop-to-quantity-for-nanvar
Oct 23, 2024
Merged

BUG: ensure nanvar(angle) drops to quantity (instead of raising)#17239
mhvk merged 2 commits intoastropy:mainfrom
mhvk:angle-drop-to-quantity-for-nanvar

Conversation

@mhvk
Copy link
Contributor
@mhvk mhvk commented Oct 23, 2024

As found in #17221 (comment), np.nanvar(angle) raises an exception on main, because in the numpy implementation an in-place multication is done that changes the unit, making it inconsistent with an Angle. This PR fixes that.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@mhvk mhvk added this to the v7.0.0 milestone Oct 23, 2024
@github-actions
Copy link
Contributor
github-actions bot commented Oct 23, 2024

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@mhvk mhvk mentioned this pull request Oct 23, 2024
Open
larrybradley
larrybradley approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member
@larrybradley larrybradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

8000
@mhvk mhvk merged commit e50acd2 into astropy:main Oct 23, 2024
@neutrinoceros
Copy link
Contributor
neutrinoceros commented Oct 23, 2024

Should this be backported ?

@pllim
Copy link
Member
pllim commented Oct 23, 2024

Would the code suddenly working breaks downstream? 🤷‍♀️

@mhvk
Copy link
Contributor Author
mhvk commented Oct 23, 2024

No, this only ensures that code that previously breaks now works. So, yes, I should have set the milestone to backport...

@neutrinoceros
Copy link
Contributor
neutrinoceros commented Oct 23, 2024

@meeseeksdev backport to v6.1.x

meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Oct 23, 2024
@mhvk @meeseeksmachine
Backport PR astropy#17239: BUG: ensure nanvar(angle) drops to quantit…
e515cd9 
…y (instead of raising)
@neutrinoceros neutrinoceros modified the milestones: v7.0.0, v6.1.5 Oct 23, 2024
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 23, 2024
Merged
pllim added a commit that referenced this pull request Oct 23, 2024
@pllim
Merge pull request #17240 from meeseeksmachine/auto-backport-of-pr-17…
cf56d54 
…239-on-v6.1.x

Backport PR #17239 on branch v6.1.x (BUG: ensure nanvar(angle) drops to quantity (instead of raising))
@roytsmart roytsmart mentioned this pull request Nov 8, 2024
Closed
@mhvk mhvk deleted the angle-drop-to-quantity-for-nanvar branch February 17, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larrybradley larrybradley larrybradley approved these changes

Assignees

No one assigned

Labels

Bug coordinates units

Projects

None yet

Milestone

v6.1.5

Development

Successfully merging this pull request may close these issues.

4 participants

@mhvk @neutrinoceros @pllim @larrybradley
0