8000 TST: enable weekly testing against CPython 3.13 by neutrinoceros · Pull Request #16600 · astropy/astropy · GitHub
[go: up one dir, main page]
Skip to content

TST: enable weekly testing against CPython 3.13 #16600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2024
Merged

TST: enable weekly testing against CPython 3.13 #16600

merged 1 commit into from
Aug 20, 2024

Conversation

neutrinoceros
Copy link
Contributor

Description

Address the first item on #16595
Extracted from #16596

As discussed in #16596 (comment), the job currently fails (one test, or 20 variants of it, is failing), but a new beta is expected to drop sometimes next week so status may change soon.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions GitHub Actions
Copy link
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros neutrinoceros mentioned this pull request Jun 23, 2024
Merged
1 task
@neutrinoceros neutrinoceros mentioned this pull request Jun 24, 2024
Closed
21 tasks
@pllim pllim added this to the v6.1.2 milestone Jun 24, 2024
@pllim
Copy link
Member
pllim commented Jun 24, 2024

Maybe something else needs to get ported over here from your original PR? The failure was not what I thought you are describing above. Please see https://github.com/astropy/astropy/actions/runs/9650759397/job/26617100567?pr=16600

Thanks!

@neutrinoceros
Copy link
Contributor Author

Thanks, I missed that. Indeed it's an entirely new problem, so let me draft this until I can figure it out.

@neutrinoceros neutrinoceros marked this pull request as draft June 25, 2024 07:22
@neutrinoceros
Copy link
Contributor Author

Got it. I was unknowingly including matplotlib in the mix when I removed -noscipy. I put it back in and now the failure is the one I expected. Since beta3 is due today, I'll rerun CI on this PR when that version is available on GHA to see if anything changes.

@neutrinoceros
Copy link
Contributor Author

3.13.0b3 was just made available on GHA. Let's try this again.

@neutrinoceros neutrinoceros reopened this Jun 28, 2024
@neutrinoceros
Copy link
Contributor Author

Hm. Looks like weekly cron jobs don't trigger on re-opening. Let me rebase instead.

@neutrinoceros
Copy link
Contributor Author
neutrinoceros commented Jun 28, 2024 •
edited
Loading

Whoops, I always forget that I also need to wait for the new version to be registered in https://github.com/actions/python-versions/blob/main/versions-manifest.json, so the run I just triggered still used beta 2
update: watch actions/python-versions#293

@neutrinoceros neutrinoceros reopened this Jul 1, 2024
@neutrinoceros
Copy link
Contributor Author

Looks like 20min between merge of the upstream PR and triggering here wasn't enough: we still got 3.13.0b2. I'll try again tomorrow.

@neutrinoceros neutrinoceros reopened this Jul 2, 2024
@neutrinoceros
Copy link
Contributor Author

Good ! I finally got beta 3 and now there's only one failure which looks like an upstream bug, I'll report this later today !

This was referenced Jul 2, 2024
Closed
Merged
@astrofrog astrofrog modified the milestones: v6.1.2, v6.1.3 Jul 25, 2024
@neutrinoceros
Copy link
Contributor Author

simplified this now that matplotlib/matplotlib#28293 was merged

@neutrinoceros neutrinoceros marked this pull request as ready for review August 15, 2024 08:00
@pllim
Copy link
Member
pllim commented Aug 19, 2024 •
edited
Loading

I think there are no more blockers? Can use one more rebase though. Rebased.

@pllim pllim modified the milestones: v6.1.3, v7.0.0 Aug 19, 2024
@pllim pllim modified the milestones: v7.0.0, v6.1.3 Aug 19, 2024
@pllim
Copy link
Member
pllim commented Aug 19, 2024

Hmm. Let's try to backport this one. I can cherry-pick from the other PRs if needed on that backport PR.

@pllim pllim added the Build all wheels Run all the wheel builds rather than just a selection label Aug 19, 2024
@pllim pllim force-pushed the tst/weekly/cp313 branch from b96a98b to e995de0 Compare August 19, 2024 17:11
@pllim

This comment was marked as resolved.

Sign in to view
@pllim pllim force-pushed the tst/weekly/cp313 branch from e995de0 to 13992d4 Compare August 19, 2024 21:34
pllim
pllim reviewed Aug 19, 2024
View reviewed changes
Copy link
Member
@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"devdeps" can only catch so many things but we also do not want "alldeps" because some packages might not be compatible yet. This is probably good enough for now. Since this job is not required by branch protection, I will wait for all CI jobs to finish first before approving. Thanks!

pllim
pllim approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member
@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim pllim merged commit 9e88067 into astropy:main Aug 20, 2024
64 of 66 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Aug 20, 2024
@pllim @meeseeksmachine
Backport PR astropy#16600: TST: enable weekly testing against CPython…
01d8087 
… 3.13
@meeseeksmachine meeseeksmachine mentioned this pull request Aug 20, 2024
Closed
@pllim pllim mentioned this pull request Aug 20, 2024
Closed
@pllim pllim modified the milestones: v6.1.3, v7.0.0 Aug 20, 2024
@pllim
Copy link
Member
pllim commented Aug 20, 2024

I changed my mind about the backport. Updated milestone.

@neutrinoceros neutrinoceros deleted the tst/weekly/cp313 branch August 20, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pllim pllim pllim approved these changes

Assignees
No one assigned
Labels
Build all wheels Run all the wheel builds rather than just a selection Extra CI Run cron CI as part of PR no-changelog-entry-needed Python 3.13 testing
Projects
None yet
2D08 Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@neutrinoceros @pllim @astrofrog
0