8000 CLN: cleanup unused try block in astropy/convolution/convolve.py by neutrinoceros · Pull Request #16184 · astropy/astropy · GitHub
[go: up one dir, main page]
Skip to content

CLN: cleanup unused try block in astropy/convolution/convolve.py #16184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2024
Merged

CLN: cleanup unused try block in astropy/convolution/convolve.py #16184

merged 1 commit into from
Mar 11, 2024

Conversation

neutrinoceros
Copy link
Contributor
@neutrinoceros neutrinoceros commented Mar 11, 2024 •
edited
Loading

Description

As a side effect of my digging through copy=False cases (context: #16170), I found this 11 years old try block which I think is now completely redundant with how numpy.ndarray.astype works. And to make it clear (it wasn't for me), numpy 2.0 doesn't change the meaning of copy=False for astype. See numpy/numpy#25925

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions GitHub Actions
Copy link
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions GitHub Actions
Copy link
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros neutrinoceros marked this pull request as ready for review March 11, 2024 15:56
mhvk
mhvk approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor
@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird, ndarray.astype has had a copy argument for more or less forever, so I'm not sure what the intent was... Maybe just a mistaken understanding of copy? (Not illogical given that for np.array it is now being changed...). Anyway, I'll approve since the tests pass, but will not merge to give @larrybradley a chance to have a look.

@mhvk mhvk added this to the v6.1.0 milestone Mar 11, 2024
larrybradley
larrybradley approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member
@larrybradley larrybradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @neutrinoceros!

@larrybradley larrybradley merged commit 08f0889 into astropy:main Mar 11, 2024
@neutrinoceros neutrinoceros deleted the mnt/cleanup_unnecessary_try_block branch March 11, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhvk mhvk mhvk approved these changes

@larrybradley larrybradley larrybradley approved these changes

Assignees
No one assigned
Labels
convolution no-changelog-entry-needed Refactoring
Projects
None yet
Milestone
v6.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@neutrinoceros @mhvk @larrybradley
0