10000 Numpy dev and nep 50 fixes by mhvk · Pull Request #15525 · astropy/astropy · GitHub
[go: up one dir, main page]
Skip to content

Numpy dev and nep 50 fixes #15525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 25, 2023
Merged

Numpy dev and nep 50 fixes #15525

merged 4 commits into from
Oct 25, 2023

Conversation

mhvk
Copy link
Contributor
@mhvk mhvk commented Oct 24, 2023

These fixes should get us up to date to numpy-dev for the changes in casting done in numpy/numpy#23912 (following NEP 50). Also adds support (or, rather, indicate that we do not support) two string ufuncs for Quantity.

Will probably need to wait for the relevant numpy-dev wheels to come out, but at least one can test whether the tests still pass on regular numpy.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@mhvk mhvk added this to the v6.0 milestone Oct 24, 2023
@mhvk mhvk requested a review from saimn as a code owner October 24, 2023 19:03
@github-actions
Copy link
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@mhvk
Copy link
Contributor Author
mhvk commented Oct 24, 2023

The numpy-dev run still fails, because the NEP 50 changes are not yet in the nightly wheel.

@pllim
Copy link
Member
pllim commented Oct 24, 2023

Let's wait for the wheel then. Thanks!

@pllim
Copy link
Member
pllim commented Oct 25, 2023

dev deps passed now, so I am going to merge and kick off a wheel build here. Thanks!!!

@pllim pllim merged commit 41c593d into astropy:main Oct 25, 2023
@mhvk mhvk deleted the numpy-dev-and-nep-50-fixes branch October 25, 2023 16:00
@mhvk
Copy link
Contributor Author
mhvk commented Oct 25, 2023

OK, let me know if there are any problems! (I was very happy with how few changes were necessary...)

@pllim
Copy link
Member
pllim commented Oct 25, 2023

Still more than I like but hopefully they ran out of stuff to refactor by now. 😉

@mhvk mhvk mentioned this pull request Oct 30, 2023
Merged
@dhomeier dhomeier mentioned this pull request Feb 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pllim pllim pllim approved these changes

@saimn saimn Awaiting requested review from saimn saimn is a code owner

Assignees
No one assigned
Labels
coordinates io.fits no-changelog-entry-needed numpy-dev units
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mhvk @pllim
0