10000 TST: Upstream nightly wheels location has changed by pllim · Pull Request #14869 · astropy/astropy · GitHub
[go: up one dir, main page]
Skip to content

TST: Upstream nightly wheels location has changed #14869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 1, 2023
Merged

TST: Upstream nightly wheels location has changed #14869

merged 3 commits into from
Jun 1, 2023

Conversation

pllim
Copy link
Member
@pllim pllim commented May 25, 2023 •
edited
Loading

Description

A bunch of nightly wheels from upstream moved to new URL during Scientific Python Developers Summit 2023.

Make sure the devdeps job:

  1. reflects TST: test_table_group_by[True] and test_group_by_masked[True] failed with numpy 1.25rc1 #14882 (huh, did it magically disappear?!)
  2. grabs the correct dev versions
  3. mpldev should also grab matplotlib dev, fix TST: py39-test-image-mpldev-cov is not using matplotlib dev #14891

Note to self: https://anaconda.org/scipy-wheels-nightly/ (old) vs https://anaconda.org/scientific-python-nightly-wheels/ (new)

It turns out timezonefinder is pinning numpy<2 and we only use it for one line of doctest. I find this excessive, and therefore, I am removing the example. If people want to use it, they should go look at that package doc. Or if you really want this example somewhere in Astropy, please move it to tutorial. It was added (and untested) back in #11529 and then timezonefinder was added as a test dependency in #14286 .

@pllim pllim added testing no-changelog-entry-needed 💤 backport-v5.0.x on-merge: backport to v5.0.x 💤 backport-v5.3.x on-merge: backport to v5.3.x labels May 25, 2023
@pllim pllim added this to the v5.0.7 milestone May 25, 2023
@github-actions
Copy link
Contributor
github-actions bot commented May 25, 2023 •
edited by pllim
Loading

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

This comment was marked as resolved.

Sign in to view
@pllim
Copy link
Member Author
pllim commented May 25, 2023 •
edited
Loading

I think we need to wait a little and then restart the devdeps job when we think it is ready to try again. As of 2023-05-24:

Package versions: 
Numpy: 1.25.0.dev0+1532.g5d6c744db
Scipy: 1.10.1
Matplotlib: 3.7.1

And on 2023-05-30 (matplotlib is one-time manual upload for now while it waits for pandas that waits for scipy):

Numpy: 1.25.0rc1
Scipy: 1.10.1
Matplotlib: 3.8.0.dev1157+g2f778fda79

But on 2023-05-31:

Numpy: 1.24.3
Scipy: 1.12.0.dev0+1099.e38ddf1
Matplotlib: 3.8.0.dev1157+g2f778fda79

Finally:

Numpy: 2.0.0.dev0+62.gd32d6fae4
Scipy: 1.12.0.dev0+1099.e38ddf1
Matplotlib: 3.8.0.dev1157+g2f778fda79

@bsipocz bsipocz marked this pull request as ready for review May 26, 2023 17:50
@pllim pllim force-pushed the tst-scipy-night-wheel-url-update branch 2 times, most recently from f92769e to 0c3addc Compare May 31, 2023 16:34
@pllim pllim mentioned this pull request May 31, 2023
Closed
@pllim pllim force-pushed the tst-scipy-night-wheel-url-update branch from 4308645 to 2d03755 Compare May 31, 2023 22:41
@pllim @bsipocz
TST: Upstream nightly wheels location has changed
700461f 
because they moved to Scientific Python.

TST: Brute force nightly wheel installs to ensure
they upgrade. There was some mystery pinning somewhere
that prevented numpy from upgrading using PIP_EXTRA_INDEX_URL.
This is done the same way as astroquery.

Co-authored-by: Brigitta Sipőcz <bsipocz@gmail.com>
@pllim pllim force-pushed the tst-scipy-night-wheel-url-update branch from 2d03755 to 700461f Compare May 31, 2023 22:43
@pllim
Copy link
Member Author
pllim commented Jun 1, 2023

Hmmm!

timezonefinder 6.2.0 requires numpy<2,>=1.18, but you have numpy 2.0.0.dev0+62.gd32d6fae4 which is incompatible.

@pllim pllim force-pushed the tst-scipy-night-wheel-url-update branch 2 times, most recently from cac9c2c to b9becb8 Compare June 1, 2023 00:43
@pllim

This comment was marked as resolved.

Sign in to view
@pllim pllim force-pushed the tst-scipy-night-wheel-url-update branch 2 times, most recently from 06dd397 to 72a4ced Compare June 1, 2023 01:02
@pllim
Copy link
Member Author
pllim commented Jun 1, 2023 •
edited
Loading

Now it gives me

The conflict is caused by:
    matplotlib 3.8.0.dev1157+g2f778fda79 depends on cycler>=0.10
    matplotlib 3.6.0.dev3182+gd6bad5f684 depends on cycler>=0.10

I don't understand why it doesn't install its own dependencies.

UPDATE: ksunden said I need the PIP_EXTRA_INDEX_URL after all so matplotlib dev can pull in its own deps from PyPI.

@pllim pllim force-pushed the tst-scipy-night-wheel-url-update branch 2 times, most recently from beabd1e to 805697a Compare June 1, 2023 01:38
@pllim
TST: Remove timezonefinder test dependency
9b7f364 
because it is overkill to download a whole package only for one line of doctest
and also it is pinning numpy<2 that messes up our devdeps testing.

TST: Remove dev openblas library because
we do not want to build scipy from source.

TST: Now that we found out it was timezonefinder
downgrading numpy, we can reintroduce
PIP_EXTRA_INDEX_URL again.
@pllim pllim force-pushed the tst-scipy-night-wheel-url-update branch from 805697a to 9b7f364 Compare June 1, 2023 02:42
@pllim
TST: Force matplotlib dev to install in CircleCI
185cc93 
because it is not picking up mpldev for some reason
@pllim pllim added the Extra CI Run cron CI as part of PR label Jun 1, 2023
@pllim pllim requested review from a team and nstarman June 1, 2023 13:46
nstarman
nstarman approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member
@nstarman nstarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not a coords maintainer. Thanks @pllim

@pllim
Copy link
Member Author
pllim commented Jun 1, 2023

Let's do it then. Thanks!

@pllim pllim merged commit 252d5ff into astropy:main Jun 1, 2023
@pllim pllim deleted the tst-scipy-night-wheel-url-update branch June 1, 2023 18:05
@lumberbot-app

This comment was marked as resolved.

Sign in to view
@lumberbot-app

This comment was marked as resolved.

Sign in to view
pllim added a commit to pllim/astropy that referenced this pull request Jun 1, 2023
@pllim
Backport of astropy#14869 onto v5.3.x
3e4d871
This was referenced Jun 1, 2023
Merged
Merged
pllim added a commit to pllim/astropy that referenced this pull request Jun 1, 2023
@pllim
Backport of astropy#14869 onto v5.0.x
d6e64a3
This was referenced Jun 1, 2023
Merged
Closed
Open
Merged
Closed
Merged
Merged
Merged
Merged
Closed
Merged
pllim added a commit to astropy/package-template that referenced this pull request Jun 1, 2023
@pllim
Update tox.ini
6065cac 
as per astropy/astropy#14869
This was referenced Jun 1, 2023
Merged
Merged
Merged
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nstarman nstarman nstarman approved these changes

@adrn adrn Awaiting requested review from adrn

Assignees
No one assigned
Labels
Extra CI Run cron CI as part of PR no-changelog-entry-needed testing 💤 backport-v5.0.x on-merge: backport to v5.0.x 💤 backport-v5.3.x on-merge: backport to v5.3.x
Projects
None yet
Milestone
v5.0.7
Development

Successfully merging this pull request may close these issues.

TST: py39-test-image-mpldev-cov is not using matplotlib dev
2 participants
@pllim @nstarman
0