Update WCSAxes to pass multiple positional arguments to Axes
#13880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks to have worked as the dev version test is now passing. (This fix also works for sunpy: sunpy/sunpy#6500) |
pllim
approved these changes
Oct 22, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Oct 22, 2022
…al arguments to `Axes`
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Oct 22, 2022
…al arguments to `Axes`
saimn
added a commit
that referenced
this pull request
Oct 23, 2022
…880-on-v5.1.x Backport PR #13880 on branch v5.1.x (Update `WCSAxes` to pass multiple positional arguments to `Axes`)
saimn
added a commit
that referenced
this pull request
Oct 23, 2022
…880-on-v5.0.x Backport PR #13880 on branch v5.0.x (Update `WCSAxes` to pass multiple positional arguments to `Axes`)
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to address a change in the Matplotlib
Axes.__init__signature. The change in this PR should be backwards compatible with older Matplotlib versions, however, it will break code which initialisesWCSAxeswith positional arguments forwcsetc. If that's an issue, it should be possible to "clean"*argsbefore passing it toAxes.Fixes #13873
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CIlabel. Codestyle issues can be fixed by the bot.no-changelog-entry-neededlabel. If this is a manual backport, use theskip-changelog-checkslabel unless special changelog handling is necessary.astropy-botcheck might be missing; do not let the green checkmark fool you.backport-X.Y.xlabel(s) before merge.