-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
TST: Use NPY_DISABLE_CPU_FEATURES for numpy 1.22 #12684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Thank you for your draft pull request! Do you know that you can use |
which undo a bit of astropy#12655
@mhvk , do you know what is going on here in
|
Actually, looking at https://github.com/astropy/astropy/runs/4704960655?check_suite_focus=true , I am not sure if this env var is doing anything for us. @dstansby , what do you think? |
Co-authored-by: Marten van Kerkwijk <mhvk@astro.utoronto.ca>
Looks like maybe the env var did render the skipping of |
Added back in original assert, ignoring only for Gaussian2D.
Co-authored-by: William Jamieson <wjamieson@stsci.edu>
There's a line in the failing test that says:
I don't know exactly what this means, but disabling doesn't seem to have an effect. |
This actually seems to be happening on all builds, with the extra line below that I missed in my previous comment:
I'm guessing this is the list of available CPU features, so maybe try disabling all the ones in this list that start with AVX512? I have no idea why this is different to the list we disabled in MPL though... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From looking at the numpy PR (numpy/numpy#19478), I think this is the only feature that needs disabling.
Co-authored-by: David Stansby <dstansby@gmail.com> Co-authored-by: William Jamieson <wjamieson@stsci.edu>
This makes no sense to me. 🤯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps the quote marks are being included in the environment variable?
Co-authored-by: David Stansby <dstansby@gmail.com>
Hmm. Looks like we don't have to touch most of the tests if we go with #12685 . What do you think? @WilliamJamieson , do you think your modeling patch is still worth going in despite numpy issues? |
Description
This pull request is to disable numpy avx512 instructions in CI.
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CI
label.no-changelog-entry-needed
label. If this is a manual backport, use theskip-changelog-checks
label unless special changelog handling is necessary.astropy-bot
check might be missing; do not let the green checkmark fool you.backport-X.Y.x
label(s) before merge.