Fix TimeDeltaMissingUnitWarning in plot_airmass#611
Open
H-xie wants to merge 1 commit intoastropy:mainfrom
H-xie:patch-1<
8000
span class="prc-TooltipV2-Tooltip-tLeuB" data-direction="s" role="tooltip" aria-hidden="true" id="_R_1lirb1d_">H-xie/astroplan:patch-1
Open
Fix TimeDeltaMissingUnitWarning in plot_airmass#611H-xie wants to merge 1 commit intoastropy:mainfrom
TimeDeltaMissingUnitWarning in plot_airmass#611H-xie wants to merge 1 commit intoastropy:mainfrom
Conversation
The function `plot_airmass` triggers the warning `TimeDeltaMissingUnitWarning`. This issue arises from unit checks implemented in newer versions of Astropy (refer to commit d8968b29a209fdaebd0f48ff30863718bca9db78). The warning is generated because a time value without a unit is being added to an Astropy Time object. To resolve this warning, it is recommended to add the unit `u.hour` to the time value.
m4cd4r4
reviewed
Mar 13, 2026
There was a problem hiding this comment.
Clean fix for the TimeDeltaMissingUnitWarning. One thing worth checking:
In the datetime branch above this line, tzoffset is set to a bare float (from time.utcoffset().total_seconds() / 3600). If that value is later added to an astropy Time object, the same warning would appear for timezone-aware datetime inputs.
Worth adding * u.hour to the datetime branch too:
tzoffset = time.utcoffset().total_seconds() / 3600 * u.hourOtherwise this is a straightforward one-liner that fixes a real warning. Looks like it needs a rebase to trigger CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
plot_airmasstriggers the warningTimeDeltaMissingUnitWarning. This issue arises from unit checks implemented in newer versions of Astropy (refer to commit d8968b29a209fdaebd0f48ff30863718bca9db78).The warning is generated because a time value without a unit is being added to an Astropy Time object. To resolve this warning, it is recommended to add the unit
u.hourto the time value.