8000 Update pre-commit documentation by charliermarsh · Pull Request #57 · astral-sh/ruff-pre-commit · GitHub
[go: up one dir, main page]
Skip to content

Update pre-commit documentation #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2023
Merged

Update pre-commit documentation #57

merged 1 commit into from
Nov 7, 2023

Conversation

charliermarsh
Copy link
Member
@charliermarsh charliermarsh commented Nov 7, 2023 •
edited
Loading

I got some feedback on Mastodon that it wasn't clear how to use the linter and formatter together in pre-commit.

This also removes --exit-non-zero-on-fix, since pre-commit already exits if files are changed, and changes our recommendation to always put the formatter after the linter, since if a previous tool ends up committing changes, pre-commit should fail anyway.

@charliermarsh charliermarsh requested a review from zanieb November 7, 2023 16:29
@charliermarsh charliermarsh merged commit f1ef5ac into main Nov 7, 2023
@charliermarsh charliermarsh deleted the charlie/pre-commit branch November 7, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charliermarsh @zanieb
0