[flake8-2020] Fix diagnostic message for != comparisons (YTT201)
#18293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MichaReiser
reviewed
May 25, 2025
| @@ -88,12 +88,23 @@ impl Violation for SysVersionCmpStr3 { | |||
| /// - [Python documentation: `sys.version`](https://docs.python.org/3/library/sys.html#sys.version) | |||
| /// - [Python documentation: `sys.version_info`](https://docs.python.org/3/library/sys.html#sys.version_info) | |||
| #[derive(ViolationMetadata)] | |||
| pub(crate) struct SysVersionInfo0Eq3; | |||
| pub(crate) struct SysVersionInfo0Eq3 { | |||
| op: CmpOp, | |||
There was a problem hiding this comment.
I'd prefer a boolean saying if it's == or !=. Took me a while to realise that the rule doesn't support other compare operators
| @@ -246,7 +257,7 @@ pub(crate) fn compare(checker: &Checker, left: &Expr, ops: &[CmpOp], comparators | |||
| { | |||
| if *n == 3 && checker.enabled(Rule::SysVersionInfo0Eq3) { | |||
| checker.report_diagnostic(Diagnostic::new( | |||
| SysVersionInfo0Eq3, | |||
| SysVersionInfo0Eq3 { op: ops[0] }, | |||
There was a problem hiding this comment.
nit: use operator @ in the let arm instead of retrieving it form ops[0]
|
You can't, it doesn't support any kind of iteration. |
flake8-2020] Fix diagnostic message for != comparisons (YTT201)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #18292.