8000 [UP031] When encountering `"%s" % var` offer unsafe fix by plredmond · Pull Request #11019 · astral-sh/ruff · GitHub
[go: up one dir, main page]
Skip to content

[UP031] When encountering "%s" % var offer unsafe fix #11019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plredmond merged 12 commits into from
Apr 22, 2024
Merged

[UP031] When encountering "%s" % var offer unsafe fix #11019

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d8c2a2a
[ruff UP031, issue #10187] change docs to clarify the fix-offered and…
plredmond Apr 18, 2024
3a74c88
[ruff UP031, issue #10187] change docs to put the example ahead of th…
plredmond Apr 18, 2024
0826eac
[ruff UP031, issue #10187] deref and handle tuples specially; tests n…
plredmond Apr 18, 8000 2024
b0791cf
[ruff UP031, issue #10187] emit the diagnostic even when we cannot em…
plredmond Apr 18, 2024
d8f3f86
[ruff UP031, issue #10187] move "false negatives" from UP031_1.py to …
plredmond Apr 18, 2024
3f73ca8
[ruff UP031, issue #10187] cargo insta review
plredmond Apr 19, 2024
27dbae9
[ruff UP031, issue #10187] explain when a fix will(not) be offered in
plredmond Apr 19, 2024
e86dd7d
[ruff UP031, issue #10187] cargo clippy
plredmond Apr 19, 2024
210613d
[ruff UP031, issue #10187] change docs "known problems" to "fix safet…
plredmond Apr 19, 2024
8d74c0f
[ruff UP031, issue #10187] remove test examples meant to exercise the…
plredmond Apr 19, 2024
08ec1d3
[ruff UP031, issue #10187] offer the fix regardless of whether the am…
plredmond Apr 19, 2024
8c52f88
[ruff UP031, issue #10187] cargo insta review - small change from the…
plredmond Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[ruff UP031, issue #10187] change docs "known problems" to "fix safet… 
…y" and change the prose to follow
  • Loading branch information
@plredmond
plredmond committed Apr 19, 2024
commit 210613de31213d7695e44d4212543016b719f72c
10 changes: 4 additions & 6 deletions crates/ruff_linter/src/rules/pyupgrade/rules/printf_string_formatting.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ use crate::rules::pyupgrade::helpers::curly_escape;
/// "{}, {}".format("Hello", "World") # "Hello, World"
/// ```
///
/// ## Known problems
/// This rule is unable to offer a fix in cases where the format string
/// contains a single, generic format specifier (e.g. `%s`), and the right-hand side
/// is an ambiguous expression.
/// ## Fix safety
/// In cases where the format string contains a single generic format specifier
/// (e.g. `%s`), and the right-hand side is an ambiguous expression,
/// we cannot offer a safe fix.
///
/// For example, given:
/// ```python
Expand All @@ -63,8 +63,6 @@ use crate::rules::pyupgrade::helpers::curly_escape;
/// print("%s" % val) # "1"
/// print("{}".format(val)) # "(1,)"
/// ```
/// In most cases, where `val` is not a literal that our analysis can locate,
/// no fix will be offered (but in these specific examples, a fix exists).
///
/// ## References
/// - [Python documentation: `printf`-style String Formatting](https://docs.python.org/3/library/stdtypes.html#old-string-formatting)
Expand Down
0