-
-
Notifications
You must be signed in to change notification settings - Fork 192
Update to 3.14.0b1 #610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
zanieb
wants to merge
14
commits into
main
Choose a base branch
from
zb/14b1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+142
−39
Draft
Update to 3.14.0b1 #610
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
a473674
Update to 3.14b1
Wingysam 88469ad
Add `_remote_debugging`
zanieb 5a259c1
Add `_zstd`
zanieb a1ace54
Add `_contextvars` as `config-c-only`
zanieb 414e4a1
Drop `_testexternalinspection`
zanieb d081a85
Disable zstd for now
zanieb b069848
fix missing symbols
geofft c023f00
_testexternalinspection turned into (public) remote_debugging
geofft f5a7bac
Update JIT patch for b1
zanieb 4a5724d
a theory
geofft d9f5072
Disable the JIT on free-threaded builds
zanieb 04ad6e9
Add zstd to Windows
zanieb 63f0d94
Updated known projects for Windows
zanieb cff40b2
Move `_zstd` to built-in module list
zanieb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -466,7 +466,8 @@ if [ -n "${CPYTHON_OPTIMIZED}" ]; then | |
|
||
# Do not enable on x86-64 macOS because the JIT requires macOS 11+ and we are currently | ||
# using 10.15 as a miniumum version. | ||
if [ "${TARGET_TRIPLE}" != "x86_64-apple-darwin" ]; then | ||
# Do not enable when free-threading, because they're not compatible yet. | ||
if [[ ! ( "${TARGET_TRIPLE}" == "x86_64-apple-darwin" || -n "${CPYTHON_FREETHREADED}" ) ]]; then | ||
CONFIGURE_FLAGS="${CONFIGURE_FLAGS} --enable-experimental-jit=yes-off" | ||
fi | ||
|
||
|
@@ -588,6 +589,13 @@ if [[ -n "${PYTHON_MEETS_MINIMUM_VERSION_3_14}" && -n "${CROSS_COMPILING}" && "$ | |
export PROFILE_TASK='-m test --pgo --ignore test_strftime_y2k' | ||
fi | ||
|
||
# ./configure tries to auto-detect whether it can build 128-bit and 256-bit SIMD helpers for HACL, | ||
# but on x86-64 that requires v2 and v3 respectively, and on arm64 the performance is bad as noted | ||
# in the comments, so just don't even try. (We should check if we can make this conditional) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @geofft can you open an issue to track this? |
||
if [[ -n "${PYTHON_MEETS_MINIMUM_VERSION_3_14}" ]]; then | ||
patch -p1 -i "${ROOT}/patch-python-configure-hacl-no-simd.patch" | ||
fi | ||
|
||
# We use ndbm on macOS and BerkeleyDB elsewhere. | ||
if [[ "${PYBUILD_PLATFORM}" = macos* ]]; then | ||
CONFIGURE_FLAGS="${CONFIGURE_FLAGS} --with-dbmliborder=ndbm" | ||
8000
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,7 +43,7 @@ _blake2: | |
minimum-python-version: "3.14" | ||
- define: _DEFAULT_SOURCE | ||
minimum-python-version: "3.14" | ||
# Disable `explicit_bzero`, it requires glib 2.25+ | ||
# Disable `explicit_bzero`, it requires glibc 2.25+ | ||
- define: LINUX_NO_EXPLICIT_BZERO | ||
minimum-python-version: "3.14" | ||
|
||
|
@@ -88,6 +88,9 @@ _collections: | |
_contextvars: | ||
sources: | ||
- _contextvarsmodule.c | ||
config-c-only-conditional: | ||
- config-c-only: true | ||
minimum-python-version: "3.14" | ||
|
||
_crypt: | ||
maximum-python-version: "3.12" | ||
|
@@ -315,12 +318,6 @@ _hmac: | |
includes: | ||
- Modules/_hacl/ | ||
- Modules/_hacl/include/ | ||
links: | ||
- :libHacl_Hash_Blake2.a | ||
- :libHacl_Hash_SHA1.a | ||
- :libHacl_Hash_SHA2.a | ||
- :libHacl_Hash_SHA3.a | ||
- :libHacl_Hash_MD5.a | ||
defines: | ||
- _BSD_SOURCE | ||
- _DEFAULT_SOURCE | ||
|
@@ -376,7 +373,6 @@ _md5: | |
sources-conditional: | ||
- source: _hacl/Hacl_Hash_MD5.c | ||
minimum-python-version: "3.12" | ||
maximum-python-version: "3.13" | ||
defines-conditional: | ||
- define: _BSD_SOURCE | ||
minimum-python-version: "3.12" | ||
|
@@ -435,6 +431,12 @@ _random: | |
sources: | ||
- _randommodule.c | ||
|
||
|
||
_remote_debugging: | ||
minimum-python-version: "3.14" | ||
sources: | ||
- _remote_debugging_module.c | ||
|
||
_scproxy: | ||
# _scproxy is Apple OS only. | ||
# APIs required by _scproxy not available on iOS. | ||
|
@@ -453,7 +455,6 @@ _sha1: | |
sources-conditional: | ||
- source: _hacl/Hacl_Hash_SHA1.c | ||
minimum-python-version: "3.12" | ||
maximum-python-version: "3.13" | ||
includes: | ||
- Modules/_hacl/include | ||
defines-conditional: | ||
|
@@ -475,7 +476,6 @@ _sha2: | |
- sha2module.c | ||
sources-conditional: | ||
- source: _hacl/Hacl_Hash_SHA2.c | ||
maximum-python-version: "3.13" | ||
includes: | ||
- Modules/_hacl/include | ||
defines: | ||
|
@@ -491,7 +491,6 @@ _sha3: | |
minimum-python-version: "3.12" | ||
- source: _hacl/Hacl_Hash_SHA3.c | ||
minimum-python-version: "3.12" | ||
maximum-python-version: "3.13" | ||
includes: | ||
- Modules/_hacl/include | ||
defines-conditional: | ||
|
@@ -617,6 +616,7 @@ _testcapi: | |
|
||
_testexternalinspection: | ||
minimum-python-version: '3.13' | ||
maximum-python-version: '3.13' | ||
sources: | ||
- _testexternalinspection.c | ||
|
||
|
@@ -645,6 +645,8 @@ _testinternalcapi: | |
minimum-python-version: "3.13" | ||
- source: _testinternalcapi/test_lock.c | ||
minimum-python-version: "3.13" | ||
- source: _testinternalcapi/complex.c | ||
minimum-python-version: "3.14" | ||
|
||
_testmultiphase: | ||
minimum-python-version: '3.9' | ||
|
@@ -769,6 +771,17 @@ _xxtestfuzz: | |
- _xxtestfuzz/_xxtestfuzz.c | ||
- _xxtestfuzz/fuzzer.c | ||
|
||
_zstd: | ||
# Disable on all targets until we add a zstd library | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will need to come before stable, I can open an issue. |
||
disabled-targets: | ||
- .* | ||
minimum-python-version: '3.14' | ||
sources: | ||
- _zstd/_zstdmodule.c | ||
- _zstd/zdict.c | ||
- _zstd/compressor.c | ||
- _zstd/decompressor.c | ||
|
||
_zoneinfo: | ||
minimum-python-version: "3.9" | ||
sources: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
diff --git a/configure.ac b/configure.ac | ||
index a7b2f62579b..06c0c0c0da0 100644 | ||
--- a/configure.ac | ||
+++ b/configure.ac | ||
@@ -7897,8 +7897,7 @@ AC_SUBST([LIBHACL_LDFLAGS]) | ||
# The SIMD files use aligned_alloc, which is not available on older versions of | ||
# Android. | ||
# The *mmintrin.h headers are x86-family-specific, so can't be used on WASI. | ||
-if test "$ac_sys_system" != "Linux-android" -a "$ac_sys_system" != "WASI" || \ | ||
- { test -n "$ANDROID_API_LEVEL" && test "$ANDROID_API_LEVEL" -ge 28; } | ||
+if false | ||
then | ||
dnl This can be extended here to detect e.g. Power8, which HACL* should also support. | ||
AX_CHECK_COMPILE_FLAG([-msse -msse2 -msse3 -msse4.1 -msse4.2],[ | ||
@@ -7930,8 +7929,7 @@ AC_SUBST([LIBHACL_BLAKE2_SIMD128_OBJS]) | ||
# Although AVX support is not guaranteed on Android | ||
# (https://developer.android.com/ndk/guides/abis#86-64), this is safe because we do a | ||
# runtime CPUID check. | ||
-if test "$ac_sys_system" != "Linux-android" -a "$ac_sys_system" != "WASI" || \ | ||
- { test -n "$ANDROID_API_LEVEL" && test "$ANDROID_API_LEVEL" -ge 28; } | ||
+if false | ||
then | ||
AX_CHECK_COMPILE_FLAG([-mavx2],[ | ||
[LIBHACL_SIMD256_FLAGS="-mavx2"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just "didn't work" in previous releases, now they made it a hard error.