10000 Add Python 3.14 support on Windows by zanieb · Pull Request #494 · astral-sh/python-build-standalone · GitHub
[go: up one dir, main page]
Skip to content

Add Python 3.14 support on Windows #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 14, 2025
Merged

Add Python 3.14 support on Windows #494

merged 3 commits into from
Jan 14, 2025

Conversation

zanieb
Copy link
Member
@zanieb zanieb commented Jan 14, 2025 •
edited
Loading

The upstream build system now requires the latest tcl/tk and we want to upgrade anyway, so that happens here as well. There are some concerns about the new zlib/msvcrt dependencies, so I'm limiting these to the 3.14a to see how it goes.

See #495

@zanieb zanieb added platform:windows Specific to the Windows platform python:3.14 labels Jan 14, 2025
Base automatically changed from zb/314a4 to main January 14, 2025 17:40
@zanieb zanieb mentioned this pull request Jan 14, 2025
Merged
zanieb added a commit that referenced this pull request Jan 14, 2025
@zanieb @indygreg
Upgrade tcl/tk from 8.6.12 to 8.6.14 on Unix (#495)
6f3ab98 
Rebase of #313 to only apply to Unix. We'll handle Windows separately in
#494.

---------

Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
@zanieb zanieb marked this pull request as ready for review January 14, 2025 21:36
@zanieb
Copy link
Member Author
zanieb commented Jan 14, 2025

Note to self need to revert #478

@zanieb zanieb merged commit 658bff8 into main Jan 14, 2025
14 checks passed
@zanieb zanieb deleted the zb/314win branch January 14, 2025 22:12
Gankra
Gankra reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor
@Gankra Gankra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches what we discussed, I maybe would have noted the msvcrt linkage is an artifact of the binary being built for mingw / windows-gnu, which is probably being done to cross-compile the binary from linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gankra Gankra Gankra left review comments

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
platform:windows Specific to the Windows platform python:3.14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zanieb @Gankra @charliermarsh
0