8000 Updated is_of_type() check to work better with Python 3 by skippyprime · Pull Request #57 · assertpy/assertpy · GitHub
[go: up one dir, main page]
Skip to content

Updated is_of_type() check to work better with Python 3 #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
saturnboy merged 1 commit into from
Aug 13, 2016
Merged

Updated is_of_type() check to work better with Python 3 #57

saturnboy merged 1 commit into from
Aug 13, 2016

Conversation

@skippyprime
Copy link
Contributor
@skippyprime skippyprime commented Aug 8, 2016

The metaclass check was failing for me on some python 3 testing environments with tox. All tests passing.

@coveralls
Copy link
coveralls commented Aug 8, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 99.431% when pulling f10de79 on skippyprime:metaclasses into 3d0fd62 on ActivisionGameScience:master.

@saturnboy
Copy link
Contributor
saturnboy commented Aug 13, 2016

@skippyprime thanks! I guess I probably should have used issubclass() in the first place

@saturnboy saturnboy merged commit 4e8b057 into assertpy:master Aug 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skippyprime @coveralls @saturnboy
0