8000 Watch pnpm-lock from the module extension by patrickmscott · Pull Request #2148 · aspect-build/rules_js · GitHub
[go: up one dir, main page]
Skip to content

Watch pnpm-lock from the module extension #2148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2025
Merged

Watch pnpm-lock from the module extension #2148

merged 1 commit into from
Mar 26, 2025

Conversation

patrickmscott
Copy link
Contributor

Changes are visible to end-users: no

Test plan

  • Manual testing; please provide instructions so we can reproduce:
rm pnpm-lock.yaml
bazel run @pnpm -- -C $(pwd) i --lockfile-only
bazel build //...

This will recompute transitive deps in pnpm-lock.yaml and the build should pass now.

@CLAassistant
Copy link
CLAassistant commented Mar 26, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@aspect-workflows Aspect Workflows
Copy link
aspect-workflows bot commented Mar 26, 2025 •
edited
Loading

Test

All tests were cache hits

236 tests (100.0%) were fully cached saving 33s.

Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 502ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 169ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 2s.

Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 448ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 533ms.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 268ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 603ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 98ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 253ms.

Test

e2e/pnpm_lockfiles

All tests were cache hits

42 tests (100.0%) were fully cached saving 3s.

Test

e2e/pnpm_workspace

All tests were cache hits

10 tests (100.0%) were fully cached saving 2s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

12 tests (100.0%) were fully cached saving 2s.

Test

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 404ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 187ms.

Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 173ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 99ms.

Buildifier      Format

@patrickmscott patrickmscott force-pushed the patrick/watch-pnpm-lock branch from 9cf44fa to 7a32ffc Compare March 26, 2025 19:08
@jbedard jbedard enabled auto-merge (squash) March 26, 2025 19:15
@jbedard jbedard merged commit 0b21e0b into aspect-build:main Mar 26, 2025
98 checks passed
@patrickmscott patrickmscott deleted the patrick/watch-pnpm-lock branch March 26, 2025 19:32
jdarpinian pushed a commit to jdarpinian/rules_js that referenced this pull request May 9, 2025
@patrickmscott @jdarpinian
fix: watch pnpm-lock from the module extension (aspect-build#2148)
07e309b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbedard jbedard jbedard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrickmscott @CLAassistant @jbedard
0