8000 fix: quotes within js_image_layer regexes by jbedard · Pull Request #2145 · aspect-build/rules_js · GitHub
[go: up one dir, main page]
Skip to content

fix: quotes within js_image_layer regexes #2145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

fix: quotes within js_image_layer regexes #2145

merged 1 commit into from
Mar 24, 2025

Conversation

jbedard
Copy link
Member
@jbedard jbedard commented Mar 23, 2025

The js_image_layer user should only have to deal with escaping issues related to putting a regex into a starlark string. Issues putting that regex into a js RegExp object should not be exposed to the user.

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases
  • New test cases added

@jbedard jbedard requested a review from thesayyn March 23, 2025 23:11
@aspect-workflows Aspect Workflows
Copy link
aspect-workflows bot commented Mar 23, 2025 •
edited
Loading

Test

1 test target passed

Targets 
//docs:update_5_test [k8-fastbuild] 36ms

Total test execution time was 36ms. 230 tests (99.6%) were fully cached saving 33s.

Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 502ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 169ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 2s.

Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 448ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 533ms.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 268ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 603ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 98ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 253ms.

Test

e2e/pnpm_lockfiles

All tests were cache hits

42 tests (100.0%) were fully cached saving 3s.

Test

e2e/pnpm_workspace

All tests were cache hits

10 tests (100.0%) were fully cached saving 2s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

12 tests (100.0%) were fully cached saving 2s.

Test

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 404ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 187ms.

Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 173ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 99ms.

Buildifier      Format

@thesayyn thesayyn merged commit ba38f3a into aspect-build:main Mar 24, 2025
98 checks passed
@thesayyn thesayyn mentioned this pull request Mar 24, 2025
Merged
alexeagle pushed a commit to bazelbuild/bazel-central-registry that referenced this pull request Mar 26, 2025
@thesayyn
chore: yank rules_js 2.3.2 (#4125)
8b01b3c 
rules_js 2.3.2 is faulty version that breaks the public api for
js_image_layer and therefore should not be used.

aspect-build/rules_js#2145
aspect-build/rules_js#2143
aspect-build/rules_js#2142
aspect-build/rules_js#2141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesayyn thesayyn thesayyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbedard @thesayyn
0