8000 fix(coverage): ensure js_library#srcs are instrumented for coverage by alexeagle · Pull Request #2106 · aspect-build/rules_js · GitHub
[go: up one dir, main page]
Skip to content

fix(coverage): ensure js_library#srcs are instrumented for coverage #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 17, 2025
Merged

fix(coverage): ensure js_library#srcs are instrumented for coverage #2106

merged 5 commits into from
Feb 17, 2025

Conversation

alexeagle
Copy link
Member

Changes are visible to end-users: no

Test plan

  • Manual testing; please provide instructions so we can reproduce:

See comment in the source file where I added repro

@alexeagle alexeagle requested a review from thesayyn February 17, 2025 17:24
@aspect-workflows Aspect Workflows
Copy link
aspect-workflows bot commented Feb 17, 2025 •
edited
Loading

Test

All tests were cache hits

213 tests (100.0%) were fully cached saving 37s.

Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 502ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 409ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 9s.

Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 555ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 575ms.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 22ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 22ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 97ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 22ms.

Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 145ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 93ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 362ms.

Test

e2e/pnpm_lockfiles

All tests were cache hits

42 tests (100.0%) were fully cached saving 3s.

Test

e2e/pnpm_workspace

All tests were cache hits

10 tests (100.0%) were fully cached saving 4s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

12 tests (100.0%) were fully cached saving 1s.

Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 276ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 115ms.

Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 116ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 181ms.

Buildifier      Format

thesayyn
thesayyn reviewed Feb 17, 2025
View reviewed changes
thesayyn
thesayyn approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member
@thesayyn thesayyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change, otherwise lgtm

@alexeagle alexeagle merged commit 549311e into main Feb 17, 2025
101 of 107 checks passed
@alexeagle alexeagle deleted the coverage branch February 17, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesayyn thesayyn thesayyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeagle @thesayyn
0